From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Brewer <ipfire-devel@grantura.co.uk> To: development@lists.ipfire.org Subject: Re: IPCop Banish Addon for IPFire Date: Mon, 07 Jan 2019 12:38:54 +0000 Message-ID: <q0vh8u$hiq$1@tuscan3.grantura.co.uk> In-Reply-To: <q0vghv$gs1$1@tuscan3.grantura.co.uk> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7940845806104841270==" List-Id: <development.lists.ipfire.org> --===============7940845806104841270== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Bob Brewer wrote: > Matthias Fischer wrote: > >> Being curious - as always - I tried to install Banish on my testmachine. >> >> But the install script has a problem: >> >> ***SNIP*** >> [root(a)ipfiretest Banish-IPFire]# ./install_Banish.sh >> Starting Banish-IPFire 1.0.1 installation >> >> Checking if files extracted to /tmp....OK! >> Checking files.........................OK! >> ...OK! >> Backing up files.....................Done! >> Extracting files.....................Done! >> Installing system files..............Done! >> Appending to files...................Done! >> Starting Banish......................./install_Banish.sh: line 258: >> /etc/rc.d/init.d/banish: No such file or directory >> Done! >> Cleaning up..........................Done! >> ***SNAP*** >> >> It seems that line 170 uses the wrong destination: >> >> ... >> /bin/cp -p Banish/etc/rc.d/init.d/rc.banish /etc/rc.d/init.d/ >> ... >> >> This should have been '/etc/rc.d/init.d/banish'!? >> >> The symlinks in line 173-175 are therefore affected, too. Banish won't >> start. >> >> I corrected this manually, seems to work. >> >> Testing... >> > > Ahhh... I made a late change to the init system and thought I had tested > it out ok on my test system here before I uploaded it. > > Thank you for the feedback, I'll create a corrected 0.2 version and upload > it to github. > Looking closer line 170 should have been: /bin/cp -p Banish/etc/rc.d/init.d/rc.banish /etc/rc.d/init.d/rc.banish then the symlinks would be OK Rob --===============7940845806104841270==--