Re: IPCop Banish Addon for IPFire

[Bob Brewer <ipfire-devel@grantura.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 2726 bytes --]

Matthias Fischer wrote:


> But still I can't add any entries. Page reloads, list stays empty. GUI
> stays empty and 'iptables' chains, too. Rule(s) seem(s) to be deleted
> right before/after adding!?
> 
> Here I tried to add '50.22.0.0/15:
> ...
> 22:08:56	banish	: Remove Banish rules
> 22:08:56	banish	: Removing Banished entries
> 22:08:56	banish	: Load Banish rules
> 22:08:56	banish	: Adding Banished entries to DROP
> 22:08:56	banish	: Regel hinzugefügt: 50.22.0.0/15
> 22:08:56	banish	: Remove Banish rules
> 22:08:56	banish	: Removing Banished entries
> 22:08:56	banish	: Load Banish rules
> 22:08:56	banish	: Adding Banished entries to DROP
> 22:08:56	banish	: Regel gelöscht:
> ...
> 
> For entries to add, must the testmachine be online!?
> 
It would seem so, my test box is connected with a static ip to the orange 
interface of my main IPFire box. The DNS is set to my ISPs DNS.

I tried reloading the rules with the red interface disconnected and iptables 
complains "iptables v1.6.2: host/network `xxx.yy.zz' not found" when trying 
to write rules for a FQDN. Presumably iptables needs an operating DNS to 
generate the rules. Other IP Address and CIDRs seem to load OK though.
Re-connecting the red interface restored functionality. 
> 
>> 
>>> 3. $Lang::tr{'apply'} - used in 'BanishGeo.cgi' line 232 - is missing in
>>> the language-files.
>>> 
>> This is a problem with the original banish distribution files. Maybe
>> there was a translation in IPCop which IPFire doesn't have, I'll add one
>> to these lang files if I can find the appropriate translations.
>> 

I checked /var/ipfire/langs/en.pl and there is a translation for 'apply' as:
'apply' => 'Apply now' and in de.pl as: 'apply' => 'Jetzt anwenden'.
The button on the Filter rule on my box is shown as 'Apply now' so it looks 
like the translation is working OK here.
> 
> Besides, all "umlauts" are looking weird in the log, as seen above:
> 
> ...
> 21:49:50	banish	: Adding Banished entries to DROP
> 21:49:50	banish	: Regel hinzugefügt: 50.22.0.0/15
>                                         ^^^
> ...
> 21:50:41	banish	: Regel gelöscht:
>                                    ^^^
I think this must be an apache problem. The umlauts in the lang files 
display OK in a text console on my box but I don't have any umlauts in my 
message logs to compare. Do the words display correctly if you grep the 
banish entries in /var/log/messages?

>> 'captive' => $Lang::tr{'Captive'},
>> with a capital 'C' and not:
> 
> It seems so. I'm running heavily tuned language files here, so I
> overlooked this. I'll take a look.

I see you generated a patch - glad I could help :)
> 

I'll upload a 0.3 version with your suggestions

Regards

Rob