From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rob Brewer <ipfire-devel@grantura.co.uk>
To: development@lists.ipfire.org
Subject: Re: ipblacklist V2
Date: Mon, 07 Feb 2022 12:58:21 +0000
Message-ID: <str51d$emq$1@tuscan3.grantura.co.uk>
In-Reply-To: <1DC94D84-CE41-4A42-8195-27E14E542AAA@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2127952985047835949=="
List-Id: <development.lists.ipfire.org>

--===============2127952985047835949==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael,


Michael Tremer wrote:

> Hello Rob,
>=20
> Thank you for your interest in working on this.
>=20
> Yes, I always thought that there was great interest in moving this over
> the line. However, I could not find where we left off here.
>=20
> There were a couple of outstanding issues that had to be resolved. I just
> couldn=E2=80=99t find my last emails. Are you aware of these?
>=20

You expect have seen the topic :

https://community.ipfire.org/t/can-i-help-progress-version2-of-ipblacklist-ad=
don/6998/18

 where Adolf has been encouraging me to look at this feature and I now have=20
a working copy on my firewall.

I believe the patches on patchwork are mostly complete and with a few=20
additions/corrections can be incorporated into the latest build.

Here is my understanding of where we are:

https://patchwork.ipfire.org/project/ipfire/patch/20200427143123.6378-9-ipfr(=
a)tfitzgeorge.me.uk/

[v2,0/8] ipblacklist: IP Address Blacklists

This patch was applied to convert V1 into V2 and used to make the the=20
remaining patches
It can safely be ignored.

[v2,1/8] ipblacklist: Main script
This is the ipblacklist main perl program. It can be incorporated without=20
problems.


[v2,2/8] ipblacklist: WUI Settings page
ipblacklist.cgi Patch can be applied without any changes.


[v2,3/8] ipblacklist: WUI Log page
ipblacklists.dat  - Needs to be modified with an additional patch to:

1)    remove - require =E2=80=9C${General::swroot}/geoip-functions.pl=E2=80=
=9D; - This isn=E2=80=99t=20
included in core 161 and not used in this program.

2)  change
        &General::readhash( =E2=80=9C/srv/web/ipfire/html/themes/=E2=80=9D.
$mainsettings{=E2=80=98THEME=E2=80=99}."/include/colors.txt", %color );
    to
        &General::readhash(=20
=E2=80=9C/srv/web/ipfire/html/themes/ipfire/include/colors.txt=E2=80=9D, %col=
or );


[v2,4/8] ipblacklist: WUI Log details page

showrequestfromblacklist.dat - Patch can be applied without any changes


[v2,5/8] ipblacklist: WUI menus, language file etc

50-firewall.menu
70-log.menu
log.dat
en.pl

Requires additional lang files for de, es, fr, it, nl, pl, ru, tr.
All others are OK

[v2,6/8] ipblacklist: Ancillary files

sources
getipsetstat.c=20
ipblacklistctrl.c

 Can be applied without any changes
=20

[v2,8/8] ipblacklist: Build infrastructure

aarch64/stage2
configroot
ipblacklist-sources
logwatch
misc-progs
common/stage2
web-user-interface
x86_64/stage2
lfs/configroot
lfs/ipblacklist-sources
lfs/logwatch
make.sh
misc-progs/Makefile

Missing Files and links:

ipblacklist.conf (for logwatch)
ipblacklist (for logwatch)
/etc/rc.d/init.d/ipblacklist (Start -up)
/etc/rc.d/rcsysinit.d/S87ipblacklist -> ../init.d/ipblacklist

I have written code for the missing files which are working on my firewall=20
and I could submit as patches if required.=20

 /usr/share/logwatch/default.conf/services/ipblacklist.conf
 /usr/share/logwatch/scripts/services/ipblacklist
 /etc/rc.d/init.d/ipblacklist=20

I haven't tried incorporating the patches as I extracted the files from=20
Patchwork and manually inserted them into my firewall for testing. I would=20
be very surprised if there were any problems  with Tim's code however.

Hope this will help to progress this very useful addition to IPFire.


Rob


--===============2127952985047835949==--