From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rob Brewer <ipfire-devel@grantura.co.uk>
To: development@lists.ipfire.org
Subject: Re: ipblacklist V2
Date: Mon, 07 Mar 2022 22:54:19 +0000
Message-ID: <t062er$ebr$1@tuscan3.grantura.co.uk>
In-Reply-To: <6475D42B-657A-4472-B003-F19B2A113D27@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4538149383042496160=="
List-Id: <development.lists.ipfire.org>

--===============4538149383042496160==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Monday 07 March 2022 20:39 Michael Tremer wrote:

> Hello Rob,
>=20
>> On 5 Mar 2022, at 21:46, Rob Brewer <ipfire-devel(a)grantura.co.uk> wrote:
>>=20
>> Hi Stefan
>>=20
>> On Saturday 05 March 2022 18:52 Stefan Schantl wrote:
>>=20
>>> Hello *,
>>>=20
>>> I've made some development progress, which I want to share here:
>>>=20
>>> Most parts of the main backend script ("ipblacklist") from Tim and Rob
>>> are ported into a new functions library (ipblocklist-functions.pl) and
>>> into the main firewall script (rules.pl).
>>>=20
>> Good
>>> This process is almost finished and currently allows to create the
>>> firewall rules, download the blocklists and to convert them into an
>>> ipset compatible format.
>>>=20
>>> Next step will be to import the frontend code (WUI) and adjust it to
>>> use the backend code (functions) from the "ipblocklist-functions.pl".
>>>=20
>>> At this time the blocklist feature should be in a use-able state again
>>> and I'll go to create an automatic update script and to import all the
>>> logging pages stuff etc.
>>>=20
>>> The development progress and single commits can be found here:
>>>=20
>>>=20
>> https://git.ipfire.org/?p=3Dpeople/stevee/ipfire-2.x.git;a=3Dshortlog;h=3D=
refs/heads/ipblocklist
>>>=20
>>> As usual please feel free to ask any questions or to share your opinion
>>> here.
>>>=20
>>> I wish you a nice day,
>>>=20
>>> -Stefan
>> Great progress. I did find a bug I introduced when I modified the ipblackl=
ist
>> V2 perl script to add a space after the log-prefix BLKLST entry to make the
>> logs compatible with other log-prefixes.
>> This affected showrequestfromblacklist.dat and the modified version
>> 'modified regex for V3 log-prefix added space' should be used.
>>=20
>> https://git.ipfire.org/?p=3Dpeople/helix/ipfire-2.x.git;a=3Dcommit;h=3D2cc=
c47f1944fcf1f8eec8ad132fa606081b21578
>=20
> Good catch, but wouldn=E2=80=99t it be helpful to add the space to all log =
prefixes so
> that it is always easily readable for humans, too?
>=20
> -Michael
>=20

I think ipblocklist was the only logfile entry to have this problem.

Rob

--===============4538149383042496160==--