From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Brewer To: development@lists.ipfire.org Subject: Re: ipblacklist V2 Date: Sun, 03 Apr 2022 22:09:58 +0100 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2809202949343387943==" List-Id: --===============2809202949343387943== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Stefan, Thank you for your update. As you probably realize I have ben using Tim's IPblacklist software modified= =20 with the below changes for the past few weeks without problems so when it is = released into IPFire, I wouldn't expect there to be any problems. Do you have= an=20 idea of the release issue you are aiming for for the IPFire version? I have now integrated my ported Banish addon into IPblacklist which allows th= e=20 user to maintain a personnel GUI based Banish list through the IPBlacklist=20 interface which I find extremely useful. It updates considerably faster now i= t=20 is using ipset rather than the original IPTables. I'll add the details to my = git=20 pages in the next few days. Rob On Sunday 03 April 2022 10:16 Stefan Schantl wrote: > Hello Rob and list, >=20 > sorry for the long delay. Finally all major problems around the > latest IDS improvements and the release around them has passed, so > let's get back to the ipblocklist feature. >=20 >> On Monday 07 March 2022 22:54 Rob Brewer wrote: >>=20 >> > On Monday 07 March 2022 20:39 Michael Tremer wrote: >> >=20 >> > > Hello Rob, >> > >=20 >> > > > On 5 Mar 2022, at 21:46, Rob Brewer < >> > > > ipfire-devel(a)grantura.co.uk> wrote: >> > > >=20 >> > > > Hi Stefan >> > > >=20 >> > > > On Saturday 05 March 2022 18:52 Stefan Schantl wrote: >> > > >=20 >> > > > > Hello *, >> > > > >=20 >> > > > > I've made some development progress, which I want to share >> > > > > here: >> > > > >=20 >> > > > > Most parts of the main backend script ("ipblacklist") from >> > > > > Tim and Rob >> > > > > are ported into a new functions library (ipblocklist- >> > > > > functions.pl) and >> > > > > into the main firewall script (rules.pl). >> > > > >=20 >> > > > Good >> > > > > This process is almost finished and currently allows to >> > > > > create the >> > > > > firewall rules, download the blocklists and to convert them >> > > > > into an >> > > > > ipset compatible format. >> > > > >=20 >> > > > > Next step will be to import the frontend code (WUI) and >> > > > > adjust it to >> > > > > use the backend code (functions) from the "ipblocklist- >> > > > > functions.pl". >> > > > >=20 >> > > > > At this time the blocklist feature should be in a use-able >> > > > > state again >> > > > > and I'll go to create an automatic update script and to >> > > > > import all the >> > > > > logging pages stuff etc. >> > > > >=20 >> > > > > The development progress and single commits can be found >> > > > > here: >> > > > >=20 >> > > > >=20 >> > > > =20 >> > > >=20 https://git.ipfire.org/?p=3Dpeople/stevee/ipfire-2.x.git;a=3Dshortlog;h=3Dref= s/heads/ipblocklist >> > > > >=20 >> > > > > As usual please feel free to ask any questions or to share >> > > > > your opinion >> > > > > here. >> > > > >=20 >> > > > > I wish you a nice day, >> > > > >=20 >> > > > > -Stefan >> > > > Great progress. I did find a bug I introduced when I modified >> > > > the >> > > > ipblacklist V2 perl script to add a space after the log-prefix >> > > > BLKLST entry >> > > > to make the logs compatible with other log-prefixes. >> > > > This affected showrequestfromblacklist.dat and the modified >> > > > version >> > > > 'modified regex for V3 log-prefix added space' should be used. >> > > >=20 >> > > > =20 >> > > >=20 https://git.ipfire.org/?p=3Dpeople/helix/ipfire-2.x.git;a=3Dcommit;h=3D2ccc47= f1944fcf1f8eec8ad132fa606081b21578 >=20 > Thanks for the fix, I've picked it up and added it to the current > development branch. >=20 >=20 https://git.ipfire.org/?p=3Dpeople/stevee/ipfire-2.x.git;a=3Dcommit;h=3D80a45= 6334fb24059e1d3585b26318b1e6124aa6f >=20 >> > >=20 >> > > Good catch, but wouldn=E2=80=99t it be helpful to add the space to all >> > > log prefixes >> > > so that it is always easily readable for humans, too? >> > >=20 >> > > -Michael >> > >=20 >> >=20 >> > I think ipblocklist was the only logfile entry to have this >> > problem. >> >=20 >> > Rob >>=20 >> I think there is a missing space in rules.pl before tha last "\" >> I think line 755 should be: >>=20 >> run("$IPTABLES -A ${blocklist}_DROP -j LOG -m limit --limit 10/second >> --log-prefix \"BLKLST_$blocklist \""); >=20 > Thanks for pointing this out - see: >=20 >=20 https://git.ipfire.org/?p=3Dpeople/stevee/ipfire-2.x.git;a=3Dcommit;h=3D84642= aadeb63eaa9c5da0e6b3236bc6731a63580 >=20 >>=20 >>=20 >> and in my ipblocklists.dat I changed your line 298 to be compatible >> with core 163 as I don't think you can change the 'theme' now >> and produced an error. >>=20 >> from: >> &General::readhash("/srv/web/ipfire/html/themes/".$mainsettings{'THE >> ME'}."/include/colors.txt", \%color); >>=20 >> to: >> &General::readhash("/srv/web/ipfire/html/themes/ipfire/include/color >> s.txt", \%color); >=20 >=20 > Fixed: >=20 >=20 https://git.ipfire.org/?p=3Dpeople/stevee/ipfire-2.x.git;a=3Dcommit;h=3Dacf4a= 99d23576556727cffabc0089306d47b2b61 >=20 >>=20 >>=20 >> Rob >> --===============2809202949343387943==--