Aw: Re: [PATCH 1/3] rrdimage: Add scripts for new graph display method

[Bernhard Bitsch <Bernhard.Bitsch@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 2528 bytes --]

Hi Leo,

yes that's exactly what I thought of.
The idea was inspired by post coming up sometimes in the community about empty graphs. Mostly just a guessing about the reason gives the solution more or less quickly/slow. Maybe the real error messages leads quicker to the issue.

Regards,
Bernhard

> Gesendet: Donnerstag, 01. April 2021 um 16:18 Uhr
> Von: "Leo Hofmann" <hofmann(a)leo-andres.de>
> An: "Bernhard Bitsch" <Bernhard.Bitsch(a)gmx.de>
> Cc: development(a)lists.ipfire.org
> Betreff: Re: [PATCH 1/3] rrdimage: Add scripts for new graph display method
>
> Hi Bernhard,
>
> yes I liked your idea of having the error message directly visible in the diagram!
> I deliberately put a typo in the RRD command. You can see the error message in the attached screenshot.
>
> Best regards,
> Leo
>
> Am 01.04.2021 um 15:58 schrieb Bernhard Bitsch:
> > Hi,
> >
> > I didn't look at your patch in depth 'til now. But the integration of the errors from RRDtool looks good. Thanks for taking my suggestion in the discussion. I wasn't able to look at this since then, but it seems to be my solution I've tried some time ago on my system.
> > Could you test it with some errors of rrdgraph()?
> >
> > Regards,
> > Bernhard
> >
> >> Gesendet: Donnerstag, 01. April 2021 um 15:36 Uhr
> >> Von: "Leo Hofmann" <hofmann(a)leo-andres.de>
> >> An: development(a)lists.ipfire.org
> >> Betreff: Re: [PATCH 1/3] rrdimage: Add scripts for new graph display method
> >>
> >> Hi all,
> >>
> >> this series of patches is a follow-up to this discussion: https://lists.ipfire.org/pipermail/development/2021-March/009523.html
> >>
> >> I decided to write a new CGI which handles the graph image generation (png). This allowed me to add new features and remove a lot of uneccessary parameter handling from the other CGIs.
> >> I think this is in presentable form now. But there are still some issues I'd like to hear your opinion on:
> >>
> >> - Because I have collected all the graph functions from the CGIs, there is now a very long if-elseif chain in getrrdimage.cgi. I tried my best to keep this as readable as possible. But I'd be happy to rewrite that if someone knows a better method.
> >>
> >> - My test system doesn't have any hardware sensors or IPsec connections. I'm pretty sure that these graphs work but I can't test them.
> >>
> >> - getrrdimage.cgi redirects graphs it can't generate to ensure compatibility with addons. Is that necessary?
> >>
> >> Happy holidays!
> >> Leo
> >>
>