From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <Bernhard.Bitsch@gmx.de>
To: development@lists.ipfire.org
Subject:
 Aw: Re: [PATCH 1/3] rrdimage: Add scripts for new graph display method
Date: Thu, 01 Apr 2021 17:09:28 +0200
Message-ID:
 <trinity-0114451c-6523-4dd5-bac8-40a6d354c5a5-1617289768576@3c-app-gmx-bap37>
In-Reply-To: <7f0b70ed-b52f-aeb6-048d-580a696d7993@leo-andres.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6389003811167432526=="
List-Id: <development.lists.ipfire.org>

--===============6389003811167432526==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Leo,

yes that's exactly what I thought of.
The idea was inspired by post coming up sometimes in the community about empt=
y graphs. Mostly just a guessing about the reason gives the solution more or =
less quickly/slow. Maybe the real error messages leads quicker to the issue.

Regards,
Bernhard

> Gesendet: Donnerstag, 01. April 2021 um 16:18 Uhr
> Von: "Leo Hofmann" <hofmann(a)leo-andres.de>
> An: "Bernhard Bitsch" <Bernhard.Bitsch(a)gmx.de>
> Cc: development(a)lists.ipfire.org
> Betreff: Re: [PATCH 1/3] rrdimage: Add scripts for new graph display method
>
> Hi Bernhard,
>
> yes I liked your idea of having the error message directly visible in the d=
iagram!
> I deliberately put a typo in the RRD command. You can see the error message=
 in the attached screenshot.
>
> Best regards,
> Leo
>
> Am 01.04.2021 um 15:58 schrieb Bernhard Bitsch:
> > Hi,
> >
> > I didn't look at your patch in depth 'til now. But the integration of the=
 errors from RRDtool looks good. Thanks for taking my suggestion in the discu=
ssion. I wasn't able to look at this since then, but it seems to be my soluti=
on I've tried some time ago on my system.
> > Could you test it with some errors of rrdgraph()?
> >
> > Regards,
> > Bernhard
> >
> >> Gesendet: Donnerstag, 01. April 2021 um 15:36 Uhr
> >> Von: "Leo Hofmann" <hofmann(a)leo-andres.de>
> >> An: development(a)lists.ipfire.org
> >> Betreff: Re: [PATCH 1/3] rrdimage: Add scripts for new graph display met=
hod
> >>
> >> Hi all,
> >>
> >> this series of patches is a follow-up to this discussion: https://lists.=
ipfire.org/pipermail/development/2021-March/009523.html
> >>
> >> I decided to write a new CGI which handles the graph image generation (p=
ng). This allowed me to add new features and remove a lot of uneccessary para=
meter handling from the other CGIs.
> >> I think this is in presentable form now. But there are still some issues=
 I'd like to hear your opinion on:
> >>
> >> - Because I have collected all the graph functions from the CGIs, there =
is now a very long if-elseif chain in getrrdimage.cgi. I tried my best to kee=
p this as readable as possible. But I'd be happy to rewrite that if someone k=
nows a better method.
> >>
> >> - My test system doesn't have any hardware sensors or IPsec connections.=
 I'm pretty sure that these graphs work but I can't test them.
> >>
> >> - getrrdimage.cgi redirects graphs it can't generate to ensure compatibi=
lity with addons. Is that necessary?
> >>
> >> Happy holidays!
> >> Leo
> >>
>

--===============6389003811167432526==--