Hi,

just another thing I noticed in testing your .cgi.
The definitions for DNS server etc. should be outside the pool definition. They should be used by the fixed leases also.

Regards,
Bernhard

> Gesendet: Samstag, 14. November 2020 um 23:13 Uhr
> Von: "Adolf Belka" <ahb.ipfire(a)gmail.com>
> An: "Matthias Fischer" <matthias.fischer(a)ipfire.org>, "IPFire: Development-List" <development(a)lists.ipfire.org>
> Betreff: Re: Testing required for modified dhcp.cgi file related to bug 10743
>
> Hi Matthias,
>
> I have added your feedback into bugzilla.
>
> After I read your input and looked at my changes I had one of those
> "Duh, that's so obvious, why on earth did I do that"
> moments. I know the error I made and I have a reasonable idea of how I can fix it.
>
> Will send out a diff once I have made and tested the changes.
> Thanks very much for the help, much appreciated.
>
> Regards,
> Adolf.
>
>
> On 14/11/2020 17:26, Matthias Fischer wrote:
> > Hi,
> >
> > Tested - sorry, didn't work - 'dhcp' wouldn't start. Perhaps my fault. I
> > have suspected something like this for my machine.
> >
> > /var/log/messages tells me:
> >
> > ...
> > Nov 14 16:36:27 ipfire dhcpd: /etc/dhcp/dhcpd.conf line 16: Pool
> > declaration with no address range.
> > Nov 14 16:36:27 ipfire dhcpd:      }
> > Nov 14 16:36:27 ipfire dhcpd:       ^
> > Nov 14 16:36:27 ipfire dhcpd: Pool declarations must always contain at least
> > Nov 14 16:36:27 ipfire dhcpd: one range statement.
> > Nov 14 16:36:27 ipfire dhcpd: /etc/dhcp/dhcpd.conf line 30: Pool
> > declaration with no address range.
> > Nov 14 16:36:27 ipfire dhcpd:      }
> > Nov 14 16:36:27 ipfire dhcpd:       ^
> > Nov 14 16:36:27 ipfire dhcpd: Pool declarations must always contain at least
> > Nov 14 16:36:27 ipfire dhcpd: one range statement.
> > Nov 14 16:36:27 ipfire dhcpd: Configuration file errors encountered --
> > exiting
> > ...
> >
> > And...yes... [Hrm!]...I'm running 'dhcpd' on GREEN and BLUE with NO
> > address pools. Only fixed leases.
> >
> > Anything I can do to test this without address ranges?
> >
> > Best,
> > Matthias
> >
> > On 14.11.2020 13:29, Adolf Belka wrote:
> >> Hi all,
> >>
> >> I created a modified dhcp.cgi file for bug 10743. This gives the opportunity to add deny unknown-clients or deny known-clients to the dhcpd.conf file for the green and blue subnets.
> >>
> >> Unfortunately one of the bug originators has decided to move away from IPFire and will not carry out any testing of this modification to confirm it works before I create a patch and submit it.
> >>
> >> The modification provides a radio button set to green and blue that offers:-
> >>
> >> allow all clients
> >> deny unknown-clients
> >> deny known-clients
> >>
> >> The allow all clients option gives the same setup as currently and is the default setting for the radio button set.
> >>
> >> The modified dhcp.cgi file is attached. I would appreciate it if you could test this out and let me know if there are any unexpected outcomes.
> >>
> >> Regards,
> >>
> >> Adolf.
> >>
> >
>