public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <Bernhard.Bitsch@gmx.de>
To: development@lists.ipfire.org
Subject: Aw: Re:  GUI for WLanAP doesn't reflect current settings for 'noscan' option
Date: Sat, 09 Mar 2019 22:19:17 +0100	[thread overview]
Message-ID: <trinity-22559968-f7cd-4b87-abb2-9ba4f0352c8c-1552166357318@3c-app-gmx-bs71> (raw)
In-Reply-To: <9968de9b-3772-da9e-3672-2e70bcf2bbc6@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2347 bytes --]

Hi Matthias,

> Gesendet: Samstag, 09. März 2019 um 21:59 Uhr
> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
> An: "Bernhard Bitsch" <Bernhard.Bitsch(a)gmx.de>, "IPFire Development" <development(a)lists.ipfire.org>
> Betreff: Re: Aw: GUI for WLanAP doesn't reflect current settings for 'noscan' option
>
> Hi Bernhard,
> 
> On 09.03.2019 21:15, Matthias Fischer wrote:
> > ...
> >>> Can anyone confirm?
> >>> 
> >> Cannot confirm this. The WUI just shows the last saved stated as checked. 
> >> Switch to off / save --> off is checked
> >> Switch to on / save  --> on is checked
> 
> Hm.
> 
> Could you please check the resulting values for ON and OFF settings?
> 
> Here:
> 
> wlanap.cgi - ON is checked:
> /var/ipfire/wlanap/hostapd.conf => noscan=1
> /var/ipfire/wlanap/settings => NOSCAN=on
> 
> wlanap.cgi - OFF is checked:
> /var/ipfire/wlanap/hostapd.conf => noscan=0
> /var/ipfire/wlanap/settings => NOSCAN=OFF
> 
> Do you get the same results?
> 
> Best,
> Matthias
> 

No, it's just the other way. Just as the original line reads, I think.
I also checked the functionality. If I check "Neighbourhood scan=off" hostapd generates a 40MHZ signal, and vice versa.
The semantics are ok also: "Neighbour scan=off" --> scan --> noscan=0.

Best, 
Bernhard

> >> Best,
> >> Bernhard
> > 
> > Thanks for the feedback, but that is strange.
> > 
> > To get it working as expected, I had to change line 423 from:
> > 
> > <tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> | <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>
> > 
> > To:
> > 
> > <tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> | <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>
> > 
> > Don't know if I'm just puzzled, but whatever I did, ON remained checked.
> > 
> > Will take a closer look again.
> > 
> > Best,
> > Matthias
> > 
> 
>

  reply	other threads:[~2019-03-09 21:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-09 17:54 Matthias Fischer
2019-03-09 19:48 ` Aw: " Bernhard Bitsch
2019-03-09 20:15   ` Matthias Fischer
2019-03-09 20:59     ` Matthias Fischer
2019-03-09 21:19       ` Bernhard Bitsch [this message]
2019-03-09 22:21         ` Aw: " Matthias Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=trinity-22559968-f7cd-4b87-abb2-9ba4f0352c8c-1552166357318@3c-app-gmx-bs71 \
    --to=bernhard.bitsch@gmx.de \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox