From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <Bernhard.Bitsch@gmx.de>
To: development@lists.ipfire.org
Subject: Aw: Re: Patch for bugzilla #12050, try #2
Date: Mon, 15 Apr 2019 20:49:42 +0200
Message-ID:
 <trinity-38b5454a-5d1d-49f9-9cff-2391fb7318b2-1555354181990@3c-app-gmx-bs79>
In-Reply-To: <ED757673-6705-4E5F-8D83-C54B8E6ADD81@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8464347956340082790=="
List-Id: <development.lists.ipfire.org>

--===============8464347956340082790==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael,

I know the "normal way" to send patches.
But I do not have a up-to-date git repo at the moment, reasons exist but aren=
't of interest for this special case.
I have posted the entire modified dhcpi.cgi in the forum for usage. Wanted ju=
st to supply the DevList and Bugzilla with a short and fast solution, hoping =
not to be to late for the announced emergency update.

If you want, I can post the entire modified dhcp.cgi to the DevList and someo=
ne of the devs can merge it to the git repository.

- Bernhard

BTW: I'll setup my local repo again. Further patches for this and other probl=
ems and/or developments will obey the guidance from wiki.

> Gesendet: Montag, 15. April 2019 um 13:12 Uhr
> Von: "Michael Tremer" <michael.tremer(a)ipfire.org>
> An: "Bernhard Bitsch" <Bernhard.Bitsch(a)gmx.de>
> Cc: "IPFire Development" <development(a)lists.ipfire.org>
> Betreff: Re: Patch for bugzilla #12050, try #2
>
> Hi Bernhard,
>
> I am happy that you are taking a look at this bug, but this is not how the =
process works.
>
> We have a guide on how to submit patches to the mailing list:
>
>   https://wiki.ipfire.org/devel/submit-patches
>
> There are a thousand reasons why we are doing this as we are doing it. Plea=
se follow it.
>
> -Michael
>
> > On 14 Apr 2019, at 00:04, Bernhard Bitsch <Bernhard.Bitsch(a)gmx.de> wrot=
e:
> >
> > Please find appended the solution.
> >
> > Short description of the problem:
> >
> > After adding a new lease, you are in editing mode.
> > All fields are set right, but a second click ('update' ) is necessary.
> > With determining the exact mode 'add/edit' this second click can be avoid=
ed for new entries ( new MAC/IP combination).
> >
> > The patch adds determination of add/edit mode. If the MAC/IP pair exists =
in the list of fixed leases edit mode is selected, add mode is selected else.
> >
> > Sorry, did not produce the patch from git but by diffing changed file and=
 the core 129 original.
> >
> > -Bernhard
> >
> > EDIT: produced an error by blind copy & paste, should correct with this p=
atch.<dhcp.cgi.patch>
>
>

--===============8464347956340082790==--