From: Bernhard Bitsch <Bernhard.Bitsch@gmx.de>
To: development@lists.ipfire.org
Subject: Aw: Re: Confusing error message
Date: Sat, 14 Sep 2019 16:02:52 +0200 [thread overview]
Message-ID: <trinity-4c019834-dca1-4764-9d99-1433cad40812-1568469772417@3c-app-gmx-bap40> (raw)
In-Reply-To: <2c5fbfd6-c541-0c3a-bb29-37126478e64c@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
Hi,
> Gesendet: Samstag, 14. September 2019 um 15:55 Uhr
> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
> An: development(a)lists.ipfire.org
> Betreff: Re: Confusing error message
>
> Hi,
>
> On 14.09.2019 15:29, Tapani Tarvainen wrote:
> > I just spent a stupid amount of time trying to figure out why IpFire
> > insisted a fixed lease had "invalid fixed ip address" when I could
> > see nothing wrong with the address.
> >
> > I had to read the source before I realized where the problem was: the
> > same error message is also used when the *next-server* address is bad,
> > and it doesn't accept server name there but wants an IP.
>
> To be sure: do you mean this if-clause in 'dhcp.cgi'?
>
> ...
> if ($dhcpsettings{'FIX_NEXTADDR'}) {
> unless(&General::validip($dhcpsettings{'FIX_NEXTADDR'})) {
> $errormessage = $Lang::tr{'invalid fixed ip address'}; }
> }
> ...
>
> > I guess this would not be the most critical thing to fix but at least
> > changing the error message would be nice.
>
> Yep. Should be easy.
>
> Adjusting 'dhcp.cgi' and the 'lang'-string for the errormessage should
> be sufficient. I just need your confirmation.
>
> Would the errormessage 'invalid ip' => 'Invalid IP Address' be clear
> enough/sufficient?
>
> Alternative:
> 'invalid next-server ip' => 'Invalid IP Address for next-server'
>
I would prefer this version. The semantic "next-server must be a IP address" is expressed more clearly.
> Best,
> Matthias
>
Best,
Bernhard
next prev parent reply other threads:[~2019-09-14 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 13:29 Tapani Tarvainen
2019-09-14 13:55 ` Matthias Fischer
2019-09-14 14:02 ` Bernhard Bitsch [this message]
2019-09-14 14:56 ` Tapani Tarvainen
2019-09-14 16:31 ` Matthias Fischer
2019-09-14 18:09 ` Tom Rymes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-4c019834-dca1-4764-9d99-1433cad40812-1568469772417@3c-app-gmx-bap40 \
--to=bernhard.bitsch@gmx.de \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox