From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <Bernhard.Bitsch@gmx.de>
To: development@lists.ipfire.org
Subject: Aw: Re: Confusing error message
Date: Sat, 14 Sep 2019 16:02:52 +0200
Message-ID:
 <trinity-4c019834-dca1-4764-9d99-1433cad40812-1568469772417@3c-app-gmx-bap40>
In-Reply-To: <2c5fbfd6-c541-0c3a-bb29-37126478e64c@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1794716943059854006=="
List-Id: <development.lists.ipfire.org>

--===============1794716943059854006==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> Gesendet: Samstag, 14. September 2019 um 15:55 Uhr
> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
> An: development(a)lists.ipfire.org
> Betreff: Re: Confusing error message
>
> Hi,
>
> On 14.09.2019 15:29, Tapani Tarvainen wrote:
> > I just spent a stupid amount of time trying to figure out why IpFire
> > insisted a fixed lease had "invalid fixed ip address" when I could
> > see nothing wrong with the address.
> >
> > I had to read the source before I realized where the problem was: the
> > same error message is also used when the *next-server* address is bad,
> > and it doesn't accept server name there but wants an IP.
>
> To be sure: do you mean this if-clause in 'dhcp.cgi'?
>
> ...
>     if ($dhcpsettings{'FIX_NEXTADDR'}) {
>         unless(&General::validip($dhcpsettings{'FIX_NEXTADDR'})) {
> $errormessage =3D $Lang::tr{'invalid fixed ip address'}; }
>     }
> ...
>
> > I guess this would not be the most critical thing to fix but at least
> > changing the error message would be nice.
>
> Yep. Should be easy.
>
> Adjusting 'dhcp.cgi' and the 'lang'-string for the errormessage should
> be sufficient. I just need your confirmation.
>
> Would the errormessage 'invalid ip' =3D> 'Invalid IP Address' be clear
> enough/sufficient?
>
> Alternative:
> 'invalid next-server ip' =3D> 'Invalid IP Address for next-server'
>

I would prefer this version. The semantic "next-server must be a IP address" =
is expressed more clearly.

> Best,
> Matthias
>

Best,
Bernhard

--===============1794716943059854006==--