From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Bitsch To: development@lists.ipfire.org Subject: Aw: Re: [PATCH 1/3] rrdimage: Add scripts for new graph display method Date: Thu, 01 Apr 2021 15:58:15 +0200 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4046065205900558184==" List-Id: --===============4046065205900558184== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, I didn't look at your patch in depth 'til now. But the integration of the err= ors from RRDtool looks good. Thanks for taking my suggestion in the discussio= n. I wasn't able to look at this since then, but it seems to be my solution I= 've tried some time ago on my system. Could you test it with some errors of rrdgraph()? Regards, Bernhard > Gesendet: Donnerstag, 01. April 2021 um 15:36 Uhr > Von: "Leo Hofmann" > An: development(a)lists.ipfire.org > Betreff: Re: [PATCH 1/3] rrdimage: Add scripts for new graph display method > > Hi all, > > this series of patches is a follow-up to this discussion: https://lists.ipf= ire.org/pipermail/development/2021-March/009523.html > > I decided to write a new CGI which handles the graph image generation (png)= . This allowed me to add new features and remove a lot of uneccessary paramet= er handling from the other CGIs. > I think this is in presentable form now. But there are still some issues I'= d like to hear your opinion on: > > - Because I have collected all the graph functions from the CGIs, there is = now a very long if-elseif chain in getrrdimage.cgi. I tried my best to keep t= his as readable as possible. But I'd be happy to rewrite that if someone know= s a better method. > > - My test system doesn't have any hardware sensors or IPsec connections. I'= m pretty sure that these graphs work but I can't test them. > > - getrrdimage.cgi redirects graphs it can't generate to ensure compatibilit= y with addons. Is that necessary? > > Happy holidays! > Leo > --===============4046065205900558184==--