From: Bernhard Bitsch <Bernhard.Bitsch@gmx.de>
To: development@lists.ipfire.org
Subject: Aw: [PATCH] Syntax fixes in several CGIs
Date: Tue, 29 Dec 2020 14:50:49 +0100 [thread overview]
Message-ID: <trinity-80ba86de-fa32-4b4e-9361-d1c6e34eb590-1609249849345@3c-app-gmx-bs69> (raw)
In-Reply-To: <20201229125011.23920-1-matthias.fischer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 6468 bytes --]
Hi,
to avoid possible mis-interpretation by Perl we do not need to set the hash tags in '.
For example
value='$Lang::tr{'update'}'
can read
value='$Lang::tr{update}'
In most locations we use the stringifying, it is just cosmetic. Thus an overall editing is not needed.
Greets,
Bernhard
> Gesendet: Dienstag, 29. Dezember 2020 um 13:50 Uhr
> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
> An: development(a)lists.ipfire.org
> Betreff: [PATCH] Syntax fixes in several CGIs
>
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/asterisk/calls.cgi | 2 +-
> html/cgi-bin/asterisk/conf.cgi | 2 +-
> html/cgi-bin/extrahd.cgi | 4 ++--
> html/cgi-bin/gpl.cgi | 2 +-
> html/cgi-bin/hardwaregraphs.cgi | 2 +-
> html/cgi-bin/optionsfw.cgi | 4 ++--
> html/cgi-bin/upnp.cgi | 2 +-
> 7 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/html/cgi-bin/asterisk/calls.cgi b/html/cgi-bin/asterisk/calls.cgi
> index c5877b2ea..a7635f2ec 100644
> --- a/html/cgi-bin/asterisk/calls.cgi
> +++ b/html/cgi-bin/asterisk/calls.cgi
> @@ -73,7 +73,7 @@ print <<END
>
> <tr><td colspan=2>Von oder zum Anrufer mit der ID/Nummer:<td colspan=2><input type=text name=number size=20 maxlength=100 value="$cgiparams{'number'}">
>
> -<tr><td align=center colspan=4><input type=submit name='ACTION' value=$Lang::tr{'update'}>
> +<tr><td align=center colspan=4><input type=submit name='ACTION' value='$Lang::tr{'update'}'>
> </table>
> END
> ;
> diff --git a/html/cgi-bin/asterisk/conf.cgi b/html/cgi-bin/asterisk/conf.cgi
> index 2dd8cf0a8..ab5011f21 100644
> --- a/html/cgi-bin/asterisk/conf.cgi
> +++ b/html/cgi-bin/asterisk/conf.cgi
> @@ -77,7 +77,7 @@ print <<END
>
> <tr><td align=center>
> <p><input type=text name=save_path value=$conf_file size=25>
> - <p><input type=submit name=ACTION value=$Lang::tr{'save'}>
> + <p><input type=submit name=ACTION value='$Lang::tr{'save'}'>
> </table>
>
> END
> diff --git a/html/cgi-bin/extrahd.cgi b/html/cgi-bin/extrahd.cgi
> index da1efb2dd..aaf42baff 100644
> --- a/html/cgi-bin/extrahd.cgi
> +++ b/html/cgi-bin/extrahd.cgi
> @@ -156,7 +156,7 @@ END
> <input type='hidden' name='DEVICE' value='$deviceline[0]' />
> <input type='hidden' name='FS' value='$deviceline[1]' />
> <input type='hidden' name='PATH' value='$deviceline[2]' />
> - <input type='hidden' name='ACTION' value=$Lang::tr{'delete'} />
> + <input type='hidden' name='ACTION' value='$Lang::tr{'delete'}' />
> <input type='image' alt='$Lang::tr{'delete'}' title='$Lang::tr{'delete'}' src='/images/delete.gif' />
> </form></td></tr>
> END
> @@ -228,7 +228,7 @@ END
> <td align="center">
> <input type='hidden' name='DEVICE' value='$partitionline[0]' />
> <input type='hidden' name='UUID' value='$partitionline[2]' />
> - <input type='hidden' name='ACTION' value=$Lang::tr{'add'} />
> + <input type='hidden' name='ACTION' value='$Lang::tr{'add'}' />
> <input type='image' alt='$Lang::tr{'add'}' title='$Lang::tr{'add'}' src='/images/add.gif' />
> </form></td></tr>
> END
> diff --git a/html/cgi-bin/gpl.cgi b/html/cgi-bin/gpl.cgi
> index 94187ce7a..be1ea2639 100644
> --- a/html/cgi-bin/gpl.cgi
> +++ b/html/cgi-bin/gpl.cgi
> @@ -71,7 +71,7 @@ print <<END;
> <form method='post' action='$ENV{'SCRIPT_NAME'}'>
> <input type='checkbox' name='gpl_accepted' value='1'/> $Lang::tr{'gpl i accept these terms and conditions'}.
> <br/ >
> - <input type='submit' name='ACTION' value=$Lang::tr{'yes'} />
> + <input type='submit' name='ACTION' value='$Lang::tr{'yes'}' />
> </form>
> </p>
> <a href='http://www.gnu.org/licenses/translations.html' target='_blank'>$Lang::tr{'gpl unofficial translation of the general public license v3'}</a>
> diff --git a/html/cgi-bin/hardwaregraphs.cgi b/html/cgi-bin/hardwaregraphs.cgi
> index e582acfb9..5c677d815 100644
> --- a/html/cgi-bin/hardwaregraphs.cgi
> +++ b/html/cgi-bin/hardwaregraphs.cgi
> @@ -167,7 +167,7 @@ END
>
> print <<END
> <tr>
> - <td align='center' colspan='2' ><input type='submit' name='ACTION' value=$Lang::tr{'save'} /></td>
> + <td align='center' colspan='2' ><input type='submit' name='ACTION' value='$Lang::tr{'save'}' /></td>
> </tr>
> </table>
> </form>
> diff --git a/html/cgi-bin/optionsfw.cgi b/html/cgi-bin/optionsfw.cgi
> index 47aba59cb..8c996802c 100644
> --- a/html/cgi-bin/optionsfw.cgi
> +++ b/html/cgi-bin/optionsfw.cgi
> @@ -323,7 +323,7 @@ END
> <br />
> <table width='100%' cellspacing='0'>
> <tr><td align='right'><form method='post' action='$ENV{'SCRIPT_NAME'}'>
> -<input type='submit' name='ACTION' value=$Lang::tr{'save'} />
> +<input type='submit' name='ACTION' value='$Lang::tr{'save'}' />
> </form></td></tr>
> </table>
> </form>
> @@ -345,7 +345,7 @@ print <<END;
> <tr><td width='15%' align='left'> <select name='POLICY' style="width: 100px">
> <option value='MODE1' $selected{'POLICY'}{'MODE1'}>$Lang::tr{'fwdfw pol block'}</option>
> <option value='MODE2' $selected{'POLICY'}{'MODE2'}>$Lang::tr{'fwdfw pol allow'}</option></select>
> - <input type='submit' name='ACTION' value=$Lang::tr{'save'} /><input type='hidden' name='defpol' value='1'></td>
> + <input type='submit' name='ACTION' value='$Lang::tr{'save'}' /><input type='hidden' name='defpol' value='1'></td>
> END
> print "</tr></table></form>";
> print"<br><br>";
> diff --git a/html/cgi-bin/upnp.cgi b/html/cgi-bin/upnp.cgi
> index 07dfa2677..5d99d0ed7 100644
> --- a/html/cgi-bin/upnp.cgi
> +++ b/html/cgi-bin/upnp.cgi
> @@ -163,7 +163,7 @@ print <<END
> <tr><td align='left'>Downstream in KB:</td><td><input type='text' name='DOWNSTREAM' value='$upnpsettings{'DOWNSTREAM'}' size="30" /></td></tr>
> <tr><td align='left'>Upstream in KB:</td><td><input type='text' name='UPSTREAM' value='$upnpsettings{'UPSTREAM'}' size="30" /></td></tr>
> <tr><td align='left' colspan='2'><br /></td></tr>
> -<tr><td colspan='2' align='center'> <input type='hidden' name='ACTION' value=$Lang::tr{'save'} />
> +<tr><td colspan='2' align='center'> <input type='hidden' name='ACTION' value='$Lang::tr{'save'}' />
> <input type='image' alt='$Lang::tr{'save'}' title='$Lang::tr{'save'}' src='/images/floppy.gif' /></td></tr>
> </table></form>
> END
> --
> 2.18.0
>
>
next prev parent reply other threads:[~2020-12-29 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 12:50 Matthias Fischer
2020-12-29 13:50 ` Bernhard Bitsch [this message]
2020-12-29 16:51 ` Aw: " Matthias Fischer
2020-12-29 19:52 ` Aw: " Bernhard Bitsch
2020-12-30 7:31 ` Matthias Fischer
2020-12-30 10:44 ` Leo Hofmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-80ba86de-fa32-4b4e-9361-d1c6e34eb590-1609249849345@3c-app-gmx-bs69 \
--to=bernhard.bitsch@gmx.de \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox