From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Bitsch To: development@lists.ipfire.org Subject: Aw: Re: 'rrdtool 1.5.3' - errors in specific graphs - update Date: Sun, 17 May 2015 15:06:19 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2409515465506476385==" List-Id: --===============2409515465506476385== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, I added a comment about the errors to Bugzilla. Besides this specific errors, this remembered me to a general issue with the = graphics.=20 The structure is inherited from the way graphing was/is done in Smoothwall/IP= Cop: The graphics are generated periodically and saved to files. The WUI just= displays these graphic files. Errors in generation are printed to stdout. IPFire generates the graphics on-the-fly ( graphics data are output to stdout= and thus embedded directly into the HTML code ). An error output to stdout g= ives an invalid graphic element.=20 Therefore we should redesign the interface to these graphing functions allowi= ng a return of errors. I once have found a solution ( I think in assisting in development of OVPN gr= aphs ), but don't remember it in the moment.=20 UPDATE to my former post: I've found the changed files. The 'print' ( to stdout ) is simply changed to = a call of General::log. The lines read now: &General::log("Error in RRD::graph for .....: ".$ERROR)if $ERROR Bernhard --===============2409515465506476385==--