From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <Bernhard.Bitsch@gmx.de>
To: development@lists.ipfire.org
Subject: Aw: [PATCH v2 2/4] Network::network2bin: return an empty list in case
 of error
Date: Tue, 13 Feb 2018 12:52:29 +0100
Message-ID:
 <trinity-d31d620c-86ee-4cdc-8dd6-3241a0a3bfa0-1518522749150@3c-app-gmx-bs71>
In-Reply-To: <20180212221932.29122-3-berny156@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7678273739599147389=="
List-Id: <development.lists.ipfire.org>

--===============7678273739599147389==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

return ();=20
(the empty array) makes the code a bit more readable.

> Gesendet: Montag, 12. Februar 2018 um 23:19 Uhr
> Von: "Bernhard Held" <berny156(a)gmx.de>
> An: development(a)lists.ipfire.org
> Betreff: [PATCH v2 2/4] Network::network2bin: return an empty list in case =
of error
>
> 'return undef;' will always return a single value 'undef' even in list cont=
ext.
>=20
> sub foo { return undef }
> if ( my @x =3D foo() ) {
>     print "oops, we think we got a result";
> }
> ---
>  config/cfgroot/network-functions.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-f=
unctions.pl
> index 93bb646a6..41d36a194 100644
> --- a/config/cfgroot/network-functions.pl
> +++ b/config/cfgroot/network-functions.pl
> @@ -139,7 +139,7 @@ sub network2bin($) {
>  	my $netmask_bin =3D &ip2bin($netmask);
> =20
>  	if (!defined $address_bin || !defined $netmask_bin) {
> -		return undef;
> +		return;
>  	}
> =20
>  	my $network_start =3D $address_bin & $netmask_bin;
> --=20
> 2.16.1
>=20
>=20

--===============7678273739599147389==--