Re: [PATCH 1/3] sources: Removal of ALIENVAULT and SPAMHAUS_EDROP from ipblocklist sources

[Rob Brewer <ipfire-devel@grantura.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

On Sat, 20 Apr 2024 12:18:10 +0200, Adolf Belka wrote:


> I don't really understand your suggestion here. The EDROP list has gone.
> The old URL is still there but with an empty file except for the
> message.
> 
> The Spamhaus Drop list is now the equivalent of what used to be the
> Spamhaus eDrop list.
> 
> Having two entries, one called DROP and one EDROP both pointing to the
> same list seems pointless to me and potentially confusing for users as
> they might think they get something different from the two and if they
> select both they will get two sets of exactly the same IP's.
> 
> What I can do is to make a modification to the script I added to the
> update.sh file to check if SPAMHAUS_EDROP=on is set in the settings file
> and then add SPAMHAUS_DROP=on to the settings file if it is not set,
> before removing the references to SPAMHAUS_EDROP.
> 
> Regards,
> 
> Adolf

You are quite right! I misunderstood your patch because I am still on CU 
182 which doesn't have the SPAMHAUS_DROP updated sources list and was 
thinking that this was a removal  of the SPAMHAUS lists altogether. 

I see from my CU 184 system that both SPAMHAUS lists are present and 
therefore removal of SPAMHAUS_EDROP makes a lot of sense.

Sorry for the confusion.

Regards

Rob