Re: IPTraf-ng problem with version 1.1.4

Re: IPTraf-ng problem with version 1.1.4

[Erik K.]

[-- Attachment #1: Type: text/plain, Size: 3361 bytes --]

The patch seems to solve it. 

Fwd: [PATCH] BUGFIX: fix "Floating point exception" in tcplog_flowrate_msg()

> make sure interval is at least 1 (bug was made in
> "tcplog_flowrate_msg(): cleanup and fix")
> 
> Reported-by: Erik K. <ummeegge(a)ipfire.org>
> Signed-off-by: Vitezslav Samel <vitezslav(a)samel.cz>
> ---
> src/tcptable.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/tcptable.c b/src/tcptable.c
> index a4133d9..e217b19 100644
> --- a/src/tcptable.c
> +++ b/src/tcptable.c
> @@ -437,6 +437,8 @@ static char *tcplog_flowrate_msg(struct tcptableent *entry, char *buf,
> 				 size_t bufsize)
> {
> 	time_t interval = time(NULL) - entry->conn_starttime;
> +	if (interval < 1)
> +		interval = 1;
> 
> 	char rbuf[64];
> 	rate_print(entry->bcount / interval, rbuf, sizeof(rbuf));
> -- 
> 1.7.8.4

i will go for some further tests and bring it also to IPFires bugzilla for eventual news and/or other fixes.

Greetings 


Erik


Am 28.08.2013 um 20:03 schrieb Erik K.:

> Hi Michael,
> 
> Am 28.08.2013 um 13:26 schrieb Michael Tremer:
> 
>> Hi Erik,
>> 
>> On Wed, 2013-08-28 at 13:13 +0200, Erik K. wrote:
>>> Hi all,
>>> i want to report a problem with the unreleased, updated version of IPTraf-ng-1.1.4 . The problem occurs if i turn on the IPTraf logging, after a while i get an "Floating point exception" under the "Packets catured:" line and IPTraf-ng quits. Until now i couldn´t localize the problem, but it seems like a bug in the new version. 
>>> The IPTraf-ng version 1.1.3 works without this problem.
>> 
>> This is most certainly a division by zero. If you do that, the floating
>> point unit of the CPU throws a floating point exception.
>> It is best to report that to the iptraf-ng developers and open a bug
>> report about this on our own bugtracker as well, so that we can update
>> as soon as a fix is available.
> 
> i have sent an mail to IPTraf mailinglist and i´am currently compile the patched iptraf-ng source with some fixes from the community. Hope this solves the problem, will let you know this after some testing results.
> 
>> 
>>> Beside info:
>>> I have added an IPTraf-ng configuration for the logrotate.conf. In here --> http://git.ipfire.org/?p=people/ummeegge/ipfire-2.x.git;a=commit;h=16bcdaebca3586fda824e03822f82eecb796dc65 the diff can be found.
>> 
>> Should this be merged? Why is iptraf-ng writing log files any way?
> 
> I think version 1.1.3 is also pretty much up to date (on my Fedora 16 system version 1.1.1 works) and a good possibility to use IPTraf-ng nevertheless in IPFire, i don´t know how much time it takes that the above mentioned patch will be provided in the official source code and also if it solves the problem.
> 
> The logging of IPTraf-ng is very nice i think, especially with the ability of the filter usage the output can be very clear and applicable for different needs also easy to use for further processing with shell scripting. The configuration window allows to activate or deactivate the logging, so i thought it might be a good idea to add it also in logrotate.conf.
> 
>> 
>> -Michael
>> 
>> _______________________________________________
>> Development mailing list
>> Development(a)lists.ipfire.org
>> http://lists.ipfire.org/mailman/listinfo/development
>