ddns

ddns@lists.ipfire.org

38 discussions

Re: Add support for godaddy.com
by Michael Tremer 16 Mar '23

16 Mar '23

Hello again, > On 16 Mar 2023, at 10:14, Costas Tyfoxylos <costas.tyf(a)gmail.com> wrote: > > Hi Michael, > > Just briefly had a look at the code to refamiliarise myself with it and noticed that the code base is on the very old % interpolation so converting to fstrings either makes a lot of sense or none at all depending on how you look at it. :) I have also had a look at the urlopen comment you made and I cannot use the send_request method as you suggest, at least not without patching that as the headers set by it define a "Basic" authorization header with the username and password but godaddy expects an "sso-key" header instead. So I either need to bypass send_request and use url_open or patch send_request to be able to amend the authorization header with a custom entry. > What do you think? You *will* have to use send_request, because it implements so much. For example using an upstream proxy. If you omit that, your provider won’t function for those users and that would just be weird and hard to debug. Then, send_request does not require you to use HTTP Basic authentication. It will do it for you if you pass the appropriate parameters, but you don’t have to do that. If you need to pass any additional headers, there is nothing wrong with extending the function and having it take a dictionary with any additional headers. That should be a single commit, please. -Michael > kind regards > Costas > > On Thu, Mar 16, 2023 at 9:53 AM Costas Tyfoxylos <costas.tyf(a)gmail.com> wrote: > Hi Michael, > > Thanks for all the points, they all make sense, I made this patch looking at other implementations of providers so I guess some of the topics you raise are there for more of them. I will try to make some time to get an improved one in, but that will probably not be on a very short timeframe. As far as the f-strings are concerned, if I get around to fix all the other issues you mention would you like me to go over all the code base and update it to using them since they are the standard for quite some time now? I completely understand how you would not want to have an inconsistent approach to this but I can update everything if that helps more. Also if I have any issue with implementing any of the points is it ok if I reach out? > > kind regards > Costas > > On Thu, Mar 16, 2023 at 8:46 AM Michael Tremer <michael.tremer(a)ipfire.org> wrote: > Hello Costas, > > I would like to drop a couple of comments about this patch: > > It uses f-strings which we do not use at all in ddns and so I wouldn’t want to start now. > > The newly added provider class does not make use of the send_request method (https://git.ipfire.org/?p=ddns.git;a=blob;f=src/ddns/system.py;h=48c9a8f88f…) which we use to log the request, configure extra settings like an upstream proxy, etc. Just calling urlopen() is not sufficient. > > The TTL is set to 600. I cannot find anything about this in the upstream documentation, but that seems to be an eternity compared to the other providers where the TTL is at maximum 60s. If there is a way to choose, then we should use a lower value here. > > This does not support IPv6 at all. The A record is hardcoded although GoDaddy supports AAAA records, too. > > Then it is not being implemented that a record can be deleted even though the API supports it: https://developer.godaddy.com/doc/endpoint/domains#/v1/recordDeleteTypeName > > Then the error handling is incorrect as ddns handles all mentioned error codes automatically. It is not necessary to perform manual stuff here. So this is just dead code that would never be reached when using send_request(). > > I am very grateful for your patch submission but it cannot be merged like this as it introduces some major problems. Please submit an improved patch. > > Best, > -Michael > > > On 15 Mar 2023, at 12:19, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote: > > > > Hello Costas, > > > > thanks for sending your patch here and once again for sending the same > > patch as a pull request on github. > > > > I really don't know, why your first mail did not appear in my inbox, > > nor got displayed on our patchwork infrastructure. > > > > After a quick code review and some basic testing with invalid data, > > everything seems to work and I finally merged your patchset. > > > > In addition to this I tagged a new version of ddns, which will be part > > of one of the next upcomming Core updates. > > > > Best regards, > > > > -Stefan > > > > _______________________________________________ > > ddns mailing list > > ddns(a)lists.ipfire.org > > https://lists.ipfire.org/mailman/listinfo/ddns > > _______________________________________________ > ddns mailing list > ddns(a)lists.ipfire.org > https://lists.ipfire.org/mailman/listinfo/ddns

1 0

Re: Add support for godaddy.com
by Michael Tremer 16 Mar '23

16 Mar '23

Hello Costas, Thank you for your response, but please make sure to keep the list copied. > On 16 Mar 2023, at 08:53, Costas Tyfoxylos <costas.tyf(a)gmail.com> wrote: > > Hi Michael, > > Thanks for all the points, they all make sense, I made this patch looking at other implementations of providers so I guess some of the topics you raise are there for more of them. I will try to make some time to get an improved one in, but that will probably not be on a very short timeframe. As far as the f-strings are concerned, if I get around to fix all the other issues you mention would you like me to go over all the code base and update it to using them since they are the standard for quite some time now? I completely understand how you would not want to have an inconsistent approach to this but I can update everything if that helps more. Also if I have any issue with implementing any of the points is it ok if I reach out? I am not keen on f-strings as they might not be safe to use: https://bugs.python.org/issue46200 Therefore, I am not indenting to use them in any (sub-)project in an around IPFire. Please use the %-string format to keep it consistent. -Michael > > kind regards > Costas > > On Thu, Mar 16, 2023 at 8:46 AM Michael Tremer <michael.tremer(a)ipfire.org> wrote: > Hello Costas, > > I would like to drop a couple of comments about this patch: > > It uses f-strings which we do not use at all in ddns and so I wouldn’t want to start now. > > The newly added provider class does not make use of the send_request method (https://git.ipfire.org/?p=ddns.git;a=blob;f=src/ddns/system.py;h=48c9a8f88f…) which we use to log the request, configure extra settings like an upstream proxy, etc. Just calling urlopen() is not sufficient. > > The TTL is set to 600. I cannot find anything about this in the upstream documentation, but that seems to be an eternity compared to the other providers where the TTL is at maximum 60s. If there is a way to choose, then we should use a lower value here. > > This does not support IPv6 at all. The A record is hardcoded although GoDaddy supports AAAA records, too. > > Then it is not being implemented that a record can be deleted even though the API supports it: https://developer.godaddy.com/doc/endpoint/domains#/v1/recordDeleteTypeName > > Then the error handling is incorrect as ddns handles all mentioned error codes automatically. It is not necessary to perform manual stuff here. So this is just dead code that would never be reached when using send_request(). > > I am very grateful for your patch submission but it cannot be merged like this as it introduces some major problems. Please submit an improved patch. > > Best, > -Michael > > > On 15 Mar 2023, at 12:19, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote: > > > > Hello Costas, > > > > thanks for sending your patch here and once again for sending the same > > patch as a pull request on github. > > > > I really don't know, why your first mail did not appear in my inbox, > > nor got displayed on our patchwork infrastructure. > > > > After a quick code review and some basic testing with invalid data, > > everything seems to work and I finally merged your patchset. > > > > In addition to this I tagged a new version of ddns, which will be part > > of one of the next upcomming Core updates. > > > > Best regards, > > > > -Stefan > > > > _______________________________________________ > > ddns mailing list > > ddns(a)lists.ipfire.org > > https://lists.ipfire.org/mailman/listinfo/ddns > > _______________________________________________ > ddns mailing list > ddns(a)lists.ipfire.org > https://lists.ipfire.org/mailman/listinfo/ddns

1 0

Fwd: Add support for godaddy.com
by Costas Tyfoxylos 16 Mar '23

16 Mar '23

Hi, please find attached a patch for adding godaddy support to the dynamic dns settings of ipfire. Please let me know if there is anything else I need to do. The current patch has been tested on my local installation with a personal domain and seems to work as expected. kind regards Costas

3 2

Passing key algo to nsupdate
by ipfire.org＠mailgurgler.com 04 Apr '22

04 Apr '22

Dear List Trying to use nsupdate method for DDNS with my own BIND9, I fail with the WebUI. There are only three fields to provide information: Hostname, Username and Password. In my opinion nsupdates needs the - ns server address - the TSIG key name - the key algorithm - key length - dynamic host name - numerical IP address I figured out, that the ns server has to be written in the "Hostname"-field, but the rest I couldn't find out how to write the correct information. At best I get a "BAD KEY" error on my server, when I try to update the RR. Unfortunately the Wiki doesn't help, the source code I did not understand and the forum, where I posted [1] this question redirected me to this list. Can some one tell me how to use nsupdate WebUI page of IPFire? Thank you very much. Best regards, Adrian. [1] https://community.ipfire.org/t/nsupdate-ddns-for-bind-how-to-use/7629

3 3

Re: [PATCH] Fixes freedns.afraid.org ddns provider
by Michael Tremer 25 Jan '21

25 Jan '21

Hi, Thank you for updating the patch, but I think this is now what you wanted. The data= argument is back again and so we will send some data to the server which the server won’t know what to do with. You probably wanted to remove this, didn’t you? -Michael > On 22 Jan 2021, at 13:27, Kashif Iftikhar <kashif(a)compulife.com.pk> wrote: > > Hello Michael, > > Thank you for the feedback, I've sent updated (corrected) patch to ddns list. > > On Fri, Jan 22, 2021 at 6:03 PM Michael Tremer > <michael.tremer(a)ipfire.org> wrote: >> >> Hello Kashif, >> >> Thank you for your email. >> >> If the data argument is no longer required, you should remove it entirely instead of just commenting it out. >> >> Otherwise this looks good. >> >> Best, >> -Michael >> >>> On 22 Jan 2021, at 12:59, Kashif Iftikhar <kashif(a)compulife.com.pk> wrote: >>> >>> ------------------------BEGIN PATCH--------------------------- >>> From ed8e4a9e53cbd24e4a0450e3a8aa1c12359cbe2e Mon Sep 17 00:00:00 2001 >>> From: Kashif Iftikhar <kashif(a)compulife.com.pk> >>> Date: Fri, 22 Jan 2021 17:33:01 +0500 >>> Subject: [PATCH 1/1] fixes freedns.afraid.org provider. >>> >>> The URL for syncing had changed and now does not require sending the ip >>> with the request. >>> >>> Signed-off-by: Kashif Iftikhar <kashif(a)compulife.com.pk> >>> --- >>> src/ddns/providers.py | 14 +++++++------- >>> 1 file changed, 7 insertions(+), 7 deletions(-) >>> >>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>> index 56e6620..6feef33 100644 >>> --- a/src/ddns/providers.py >>> +++ b/src/ddns/providers.py >>> @@ -1186,26 +1186,26 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >>> >>> # No information about the request or response could be found on the vendor >>> # page. All used values have been collected by testing. >>> - url = "https://freedns.afraid.org/dynamic/update.php" >>> + url = "https://sync.afraid.org/u/" >>> can_remove_records = False >>> supports_token_auth = True >>> >>> def update_protocol(self, proto): >>> - data = { >>> - "address" : self.get_address(proto), >>> - } >>> + # data = { >>> + # "address" : self.get_address(proto), >>> + # } >>> >>> # Add auth token to the update url. >>> - url = "%s?%s" % (self.url, self.token) >>> + url = "%s%s/" % (self.url, self.token) >>> >>> # Send update to the server. >>> - response = self.send_request(url, data=data) >>> + response = self.send_request(url) >>> >>> # Get the full response message. >>> output = response.read().decode() >>> >>> # Handle success messages. >>> - if output.startswith("Updated") or "has not changed" in output: >>> + if output.startswith("Updated") or output.startswith("No IP >>> change detected"): >>> return >>> >>> # Handle error codes. >>> -- >>> 2.25.1 >>> >>> >>> ------------------------END PATCH--------------------------- >>> >>> Regards. >>> Kashif Iftikhar >>> http://kashif.compulife.com.pk >>> _______________________________________________ >>> ddns mailing list >>> ddns(a)lists.ipfire.org >>> https://lists.ipfire.org/mailman/listinfo/ddns >> > > > -- > Kashif Iftikhar > http://kashif.compulife.com.pk

2 2

[PATCH] Fixes freedns.afraid.org ddns provider
by Kashif Iftikhar 22 Jan '21

22 Jan '21

------------------------BEGIN PATCH--------------------------- >From ed8e4a9e53cbd24e4a0450e3a8aa1c12359cbe2e Mon Sep 17 00:00:00 2001 From: Kashif Iftikhar <kashif(a)compulife.com.pk> Date: Fri, 22 Jan 2021 17:33:01 +0500 Subject: [PATCH 1/1] fixes freedns.afraid.org provider. The URL for syncing had changed and now does not require sending the ip with the request. Signed-off-by: Kashif Iftikhar <kashif(a)compulife.com.pk> --- src/ddns/providers.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 56e6620..6feef33 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1186,26 +1186,26 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): # No information about the request or response could be found on the vendor # page. All used values have been collected by testing. - url = "https://freedns.afraid.org/dynamic/update.php" + url = "https://sync.afraid.org/u/" can_remove_records = False supports_token_auth = True def update_protocol(self, proto): - data = { - "address" : self.get_address(proto), - } + # data = { + # "address" : self.get_address(proto), + # } # Add auth token to the update url. - url = "%s?%s" % (self.url, self.token) + url = "%s%s/" % (self.url, self.token) # Send update to the server. - response = self.send_request(url, data=data) + response = self.send_request(url) # Get the full response message. output = response.read().decode() # Handle success messages. - if output.startswith("Updated") or "has not changed" in output: + if output.startswith("Updated") or output.startswith("No IP change detected"): return # Handle error codes. -- 2.25.1 ------------------------END PATCH--------------------------- Regards. Kashif Iftikhar http://kashif.compulife.com.pk

2 2

[PATCH] Add option to list-token-providers.
by Stefan Schantl 02 Dec '20

02 Dec '20

This option can be used to get a list of all known provider which support a token based authentication method. In order to provide this feature the provider details has been extended to contain the information if a provider supports this authentication method or not. Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org> --- ddns.in | 8 ++++++++ src/ddns/__init__.py | 14 ++++++++++++++ src/ddns/providers.py | 38 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 60 insertions(+) mode change 100644 => 100755 ddns.in diff --git a/ddns.in b/ddns.in old mode 100644 new mode 100755 index 0e377e7..40519c6 --- a/ddns.in +++ b/ddns.in @@ -49,6 +49,10 @@ def main(): p_list_providers = subparsers.add_parser("list-providers", help=_("List all available providers")) + # list-token-providers + p_list_providers = subparsers.add_parser("list-token-providers", + help=_("List all providers which supports authentication via token")) + # update p_update = subparsers.add_parser("update", help=_("Update DNS record")) p_update.add_argument("hostname") @@ -85,6 +89,10 @@ def main(): provider_names = d.get_provider_names() print("\n".join(provider_names)) + elif args.subparsers_name == "list-token-providers": + token_provider = d.get_provider_with_token_support() + print("\n".join(token_provider)) + elif args.subparsers_name == "update": d.updateone(hostname=args.hostname, force=args.force) diff --git a/src/ddns/__init__.py b/src/ddns/__init__.py index 3e43fa7..ca232bf 100644 --- a/src/ddns/__init__.py +++ b/src/ddns/__init__.py @@ -86,6 +86,20 @@ class DDNSCore(object): """ return sorted(self.providers.keys()) + def get_provider_with_token_support(self): + """ + Returns a list with names of all registered providers + which support token based authtentication. + """ + + token_provider = [] + + for handle, provider in sorted(self.providers.items()): + if provider.supports_token_auth is True: + token_provider.append(handle) + + return sorted(token_provider) + def load_configuration(self, filename): logger.debug(_("Loading configuration file %s") % filename) diff --git a/src/ddns/providers.py b/src/ddns/providers.py index a1ca3f3..b0066d5 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -73,6 +73,10 @@ class DDNSProvider(object): # Required to remove AAAA records if IPv6 is absent again. can_remove_records = True + # True if the provider supports authentication via a random + # generated token instead of username and password. + supports_token_auth = True + @staticmethod def supported(): """ @@ -352,6 +356,10 @@ class DDNSProtocolDynDNS2(object): # The DynDNS protocol version 2 does not allow to remove records can_remove_records = False + # The DynDNS protocol version 2 only supports authentication via + # username and password. + supports_token_auth = False + def prepare_request_data(self, proto): data = { "hostname" : self.hostname, @@ -440,6 +448,7 @@ class DDNSProviderAllInkl(DDNSProvider): url = "http://dyndns.kasserver.com" can_remove_records = False + supports_token_auth = False def update(self): # There is no additional data required so we directly can @@ -464,6 +473,8 @@ class DDNSProviderBindNsupdate(DDNSProvider): DEFAULT_TTL = 60 + supports_token_auth = False + @staticmethod def supported(): # Search if the nsupdate utility is available @@ -550,6 +561,7 @@ class DDNSProviderChangeIP(DDNSProvider): url = "https://nic.changeip.com/nic/update" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -616,6 +628,7 @@ class DDNSProviderDDNSS(DDNSProvider): url = "http://www.ddnss.de/upd.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -678,6 +691,7 @@ class DDNSProviderDHS(DDNSProvider): url = "http://members.dhs.org/nic/hosts" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -710,6 +724,7 @@ class DDNSProviderDNSpark(DDNSProvider): url = "https://control.dnspark.com/api/dynamic/update.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -758,6 +773,7 @@ class DDNSProviderDtDNS(DDNSProvider): url = "https://www.dtdns.com/api/autodns.cfm" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -813,6 +829,7 @@ class DDNSProviderDuckDNS(DDNSProvider): url = "https://www.duckdns.org/update" can_remove_records = False + supports_token_auth = True def update(self): # Raise an error if no auth details are given. @@ -914,6 +931,7 @@ class DDNSProviderDynUp(DDNSProvider): url = "https://dynup.de/dyn.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -979,6 +997,8 @@ class DDNSProviderEasyDNS(DDNSProvider): url = "http://api.cp.easydns.com/dyn/tomato.php" + supports_token_auth = False + def update_protocol(self, proto): data = { "myip" : self.get_address(proto, "-"), @@ -1032,6 +1052,7 @@ class DDNSProviderDynsNet(DDNSProvider): website = "http://www.dyns.net/" protocols = ("ipv4",) can_remove_records = False + supports_token_auth = False # There is very detailed informatio about how to send the update request and # the possible response codes. (Currently we are using the v1.1 proto) @@ -1083,6 +1104,7 @@ class DDNSProviderEnomCom(DDNSResponseParserXML, DDNSProvider): url = "https://dynamic.name-services.com/interface.asp" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -1125,6 +1147,7 @@ class DDNSProviderEntryDNS(DDNSProvider): # here: https://entrydns.net/help url = "https://entrydns.net/records/modify" can_remove_records = False + supports_token_auth = True def update_protocol(self, proto): data = { @@ -1165,6 +1188,7 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): # page. All used values have been collected by testing. url = "https://freedns.afraid.org/dynamic/update.php" can_remove_records = False + supports_token_auth = True def update_protocol(self, proto): data = { @@ -1246,6 +1270,7 @@ class DDNSProviderKEYSYSTEMS(DDNSProvider): url = "https://dynamicdns.key-systems.net/update.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): address = self.get_address(proto) @@ -1297,6 +1322,8 @@ class DDNSProviderLightningWireLabs(DDNSProvider): # Information about the format of the HTTPS request is to be found # https://dns.lightningwirelabs.com/knowledge-base/api/ddns + supports_token_auth = True + url = "https://dns.lightningwirelabs.com/update" def update(self): @@ -1365,6 +1392,7 @@ class DDNSProviderNamecheap(DDNSResponseParserXML, DDNSProvider): url = "https://dynamicdns.park-your-domain.com/update" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): # Namecheap requires the hostname splitted into a host and domain part. @@ -1458,6 +1486,8 @@ class DDNSProviderNsupdateINFO(DDNSProtocolDynDNS2, DDNSProvider): # has not been implemented here, yet. can_remove_records = False + supports_token_auth = True + # After a failed update, there will be no retries # https://bugzilla.ipfire.org/show_bug.cgi?id=10603 holdoff_failure_days = None @@ -1534,6 +1564,7 @@ class DDNSProviderRegfish(DDNSProvider): url = "https://dyndns.regfish.de/" can_remove_records = False + supports_token_auth = True def update(self): data = { @@ -1630,6 +1661,7 @@ class DDNSProviderServercow(DDNSProvider): url = "https://www.servercow.de/dnsupdate/update.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -1671,6 +1703,8 @@ class DDNSProviderSPDNS(DDNSProtocolDynDNS2, DDNSProvider): url = "https://update.spdyn.de/nic/update" + supports_token_auth = True + @property def username(self): return self.get("username") or self.hostname @@ -1774,6 +1808,8 @@ class DDNSProviderZoneedit(DDNSProvider): website = "http://www.zoneedit.com" protocols = ("ipv4",) + supports_token_auth = False + # Detailed information about the request and the response codes can be # obtained here: # http://www.zoneedit.com/doc/api/other.html @@ -1821,6 +1857,7 @@ class DDNSProviderDNSmadeEasy(DDNSProvider): url = "https://cp.dnsmadeeasy.com/servlet/updateip?" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -1871,6 +1908,7 @@ class DDNSProviderZZZZ(DDNSProvider): url = "https://zzzz.io/api/v1/update" can_remove_records = False + supports_token_auth = True def update_protocol(self, proto): data = { -- 2.20.1

1 1

[[PATCHv2]] Add option to list provider with token support.
by Stefan Schantl 02 Dec '20

02 Dec '20

This option can be used to get a list of all known provider which support a token based authentication method. In order to provide this feature the provider details has been extended to contain the information if a provider supports this authentication method or not. Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org> --- ddns.in | 8 ++++++++ src/ddns/__init__.py | 14 ++++++++++++++ src/ddns/providers.py | 38 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 60 insertions(+) mode change 100644 => 100755 ddns.in diff --git a/ddns.in b/ddns.in old mode 100644 new mode 100755 index 0e377e7..538e4b0 --- a/ddns.in +++ b/ddns.in @@ -49,6 +49,10 @@ def main(): p_list_providers = subparsers.add_parser("list-providers", help=_("List all available providers")) + # list-token-provider + p_list_token_provider = subparsers.add_parser("list-token-provider", + help=_("List all providers which supports authentication via token")) + # update p_update = subparsers.add_parser("update", help=_("Update DNS record")) p_update.add_argument("hostname") @@ -85,6 +89,10 @@ def main(): provider_names = d.get_provider_names() print("\n".join(provider_names)) + elif args.subparsers_name == "list-token-providers": + token_provider = d.get_provider_with_token_support() + print("\n".join(token_provider)) + elif args.subparsers_name == "update": d.updateone(hostname=args.hostname, force=args.force) diff --git a/src/ddns/__init__.py b/src/ddns/__init__.py index 3e43fa7..ca232bf 100644 --- a/src/ddns/__init__.py +++ b/src/ddns/__init__.py @@ -86,6 +86,20 @@ class DDNSCore(object): """ return sorted(self.providers.keys()) + def get_provider_with_token_support(self): + """ + Returns a list with names of all registered providers + which support token based authtentication. + """ + + token_provider = [] + + for handle, provider in sorted(self.providers.items()): + if provider.supports_token_auth is True: + token_provider.append(handle) + + return sorted(token_provider) + def load_configuration(self, filename): logger.debug(_("Loading configuration file %s") % filename) diff --git a/src/ddns/providers.py b/src/ddns/providers.py index a1ca3f3..b0066d5 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -73,6 +73,10 @@ class DDNSProvider(object): # Required to remove AAAA records if IPv6 is absent again. can_remove_records = True + # True if the provider supports authentication via a random + # generated token instead of username and password. + supports_token_auth = True + @staticmethod def supported(): """ @@ -352,6 +356,10 @@ class DDNSProtocolDynDNS2(object): # The DynDNS protocol version 2 does not allow to remove records can_remove_records = False + # The DynDNS protocol version 2 only supports authentication via + # username and password. + supports_token_auth = False + def prepare_request_data(self, proto): data = { "hostname" : self.hostname, @@ -440,6 +448,7 @@ class DDNSProviderAllInkl(DDNSProvider): url = "http://dyndns.kasserver.com" can_remove_records = False + supports_token_auth = False def update(self): # There is no additional data required so we directly can @@ -464,6 +473,8 @@ class DDNSProviderBindNsupdate(DDNSProvider): DEFAULT_TTL = 60 + supports_token_auth = False + @staticmethod def supported(): # Search if the nsupdate utility is available @@ -550,6 +561,7 @@ class DDNSProviderChangeIP(DDNSProvider): url = "https://nic.changeip.com/nic/update" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -616,6 +628,7 @@ class DDNSProviderDDNSS(DDNSProvider): url = "http://www.ddnss.de/upd.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -678,6 +691,7 @@ class DDNSProviderDHS(DDNSProvider): url = "http://members.dhs.org/nic/hosts" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -710,6 +724,7 @@ class DDNSProviderDNSpark(DDNSProvider): url = "https://control.dnspark.com/api/dynamic/update.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -758,6 +773,7 @@ class DDNSProviderDtDNS(DDNSProvider): url = "https://www.dtdns.com/api/autodns.cfm" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -813,6 +829,7 @@ class DDNSProviderDuckDNS(DDNSProvider): url = "https://www.duckdns.org/update" can_remove_records = False + supports_token_auth = True def update(self): # Raise an error if no auth details are given. @@ -914,6 +931,7 @@ class DDNSProviderDynUp(DDNSProvider): url = "https://dynup.de/dyn.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -979,6 +997,8 @@ class DDNSProviderEasyDNS(DDNSProvider): url = "http://api.cp.easydns.com/dyn/tomato.php" + supports_token_auth = False + def update_protocol(self, proto): data = { "myip" : self.get_address(proto, "-"), @@ -1032,6 +1052,7 @@ class DDNSProviderDynsNet(DDNSProvider): website = "http://www.dyns.net/" protocols = ("ipv4",) can_remove_records = False + supports_token_auth = False # There is very detailed informatio about how to send the update request and # the possible response codes. (Currently we are using the v1.1 proto) @@ -1083,6 +1104,7 @@ class DDNSProviderEnomCom(DDNSResponseParserXML, DDNSProvider): url = "https://dynamic.name-services.com/interface.asp" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -1125,6 +1147,7 @@ class DDNSProviderEntryDNS(DDNSProvider): # here: https://entrydns.net/help url = "https://entrydns.net/records/modify" can_remove_records = False + supports_token_auth = True def update_protocol(self, proto): data = { @@ -1165,6 +1188,7 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): # page. All used values have been collected by testing. url = "https://freedns.afraid.org/dynamic/update.php" can_remove_records = False + supports_token_auth = True def update_protocol(self, proto): data = { @@ -1246,6 +1270,7 @@ class DDNSProviderKEYSYSTEMS(DDNSProvider): url = "https://dynamicdns.key-systems.net/update.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): address = self.get_address(proto) @@ -1297,6 +1322,8 @@ class DDNSProviderLightningWireLabs(DDNSProvider): # Information about the format of the HTTPS request is to be found # https://dns.lightningwirelabs.com/knowledge-base/api/ddns + supports_token_auth = True + url = "https://dns.lightningwirelabs.com/update" def update(self): @@ -1365,6 +1392,7 @@ class DDNSProviderNamecheap(DDNSResponseParserXML, DDNSProvider): url = "https://dynamicdns.park-your-domain.com/update" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): # Namecheap requires the hostname splitted into a host and domain part. @@ -1458,6 +1486,8 @@ class DDNSProviderNsupdateINFO(DDNSProtocolDynDNS2, DDNSProvider): # has not been implemented here, yet. can_remove_records = False + supports_token_auth = True + # After a failed update, there will be no retries # https://bugzilla.ipfire.org/show_bug.cgi?id=10603 holdoff_failure_days = None @@ -1534,6 +1564,7 @@ class DDNSProviderRegfish(DDNSProvider): url = "https://dyndns.regfish.de/" can_remove_records = False + supports_token_auth = True def update(self): data = { @@ -1630,6 +1661,7 @@ class DDNSProviderServercow(DDNSProvider): url = "https://www.servercow.de/dnsupdate/update.php" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -1671,6 +1703,8 @@ class DDNSProviderSPDNS(DDNSProtocolDynDNS2, DDNSProvider): url = "https://update.spdyn.de/nic/update" + supports_token_auth = True + @property def username(self): return self.get("username") or self.hostname @@ -1774,6 +1808,8 @@ class DDNSProviderZoneedit(DDNSProvider): website = "http://www.zoneedit.com" protocols = ("ipv4",) + supports_token_auth = False + # Detailed information about the request and the response codes can be # obtained here: # http://www.zoneedit.com/doc/api/other.html @@ -1821,6 +1857,7 @@ class DDNSProviderDNSmadeEasy(DDNSProvider): url = "https://cp.dnsmadeeasy.com/servlet/updateip?" can_remove_records = False + supports_token_auth = False def update_protocol(self, proto): data = { @@ -1871,6 +1908,7 @@ class DDNSProviderZZZZ(DDNSProvider): url = "https://zzzz.io/api/v1/update" can_remove_records = False + supports_token_auth = True def update_protocol(self, proto): data = { -- 2.20.1

1 0

[PATCH] duckdns.org: Support new update API
by Stefan Schantl 10 Jul '20

10 Jul '20

The provider entirely changed the update API, which now is not longer DynDNS2 compatible, but supports IPv6 and cleaning records. Sadly they do not provide any detailed return codes in case an update fails. Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org> --- src/ddns/providers.py | 46 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 46d8a67..690516f 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -802,16 +802,54 @@ class DDNSProviderDtDNS(DDNSProvider): raise DDNSUpdateError -class DDNSProviderDuckDNS(DDNSProtocolDynDNS2, DDNSProvider): +class DDNSProviderDuckDNS(DDNSProvider): handle = "duckdns.org" name = "Duck DNS" website = "http://www.duckdns.org/" - protocols = ("ipv4",) + protocols = ("ipv6", "ipv4",) # Information about the format of the request is to be found - # https://www.duckdns.org/install.jsp + # https://www.duckdns.org/spec.jsp + + # ipv4 / ipv6 records are automatically removed during the update + # process ( clear=true ) and the ipv4 / ipv6 addresses appended. + url = "https://www.duckdns.org/update" + + def update(self): + # Raise an error if no auth details are given. + if not self.token: + raise DDNSConfigurationError + + data = { + "domains" : self.hostname, + "token" : self.token, + "ipv6" : self.get_address("ipv6", "-"), + "ip" : self.get_address("ipv4", "-"), + "clear" : "true", + } + + # Send update to the server. + response = self.send_request(self.url, data=data) + + # Get the full response message. + output = response.read().decode() + + # Remove all leading and trailing whitespace. + output = output.strip() - url = "https://www.duckdns.org/nic/update" + print(output) + + # Handle success messages. + if output == "OK": + return + + # The provider does not give detailed information + # if the update fails. Only a "KO" will be sent back. + if output == "KO": + raise DDNSUpdateError + + # If we got here, some other update error happened. + raise DDNSUpdateError class DDNSProviderDyFi(DDNSProtocolDynDNS2, DDNSProvider): -- 2.20.1

2 1

[PATCH] ProviderDDNSS: Fix unhandled exception on update
by Stefan Schantl 26 May '20

26 May '20

In python > 3.3 the getheader() attribute is not longer part of the urllib.response response.info() object. It is part of response object and so directly can be accessed. Fixes #12328 Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org> --- src/ddns/providers.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/ddns/providers.py b/src/ddns/providers.py index f1fed22..46d8a67 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -642,10 +642,8 @@ class DDNSProviderDDNSS(DDNSProvider): response = self.send_request(self.url, data=data) # This provider sends the response code as part of the header. - header = response.info() - # Get status information from the header. - output = header.getheader('ddnss-response') + output = response.getheader('ddnss-response') # Handle success messages. if output == "good" or output == "nochg": -- 2.26.1

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

ddns