Hello, Michael, did read everything, it seems that I still can't get hang of some thing. I will firstly try just to patch this bug, then try to patch for other themes and JS load execute time.
It seems hard for me to get it in format that you guys use and if some one has some template of e-mail i should use or commands you use to get that diff output, I would be grateful.
So for, I'm stuck here, still not getting output as you guys, and I know how cranky you are about submit format. :)
[PATCH] package: Typo in Traffic Meter
This solves bug 10918
Signed-off-by: Blago Culjak <blago.culjak@hotmail.com>
------------ html/html/themes/ipfire/include/js/refreshInetInfo.js ------------
index 259f86e..7d9cf8f 100644
@@ -51,7 +51,7 @@ function refreshInetInfo() {
}
function format_bytes(bytes) {
- var units = ["Bit/s", "kBit/s", "MBit/s", "GBit/s", "TBit/s"];
+ var units = ["bit/s", "kbit/s", "Mbit/s", "Gbit/s", "Tbit/s"];
var unit = units[0];
for (var i = 1; i < units.length; i++) {
> Subject: Bug #10918 was: [ANNOUNCE] Good First Bugs
> From: michael.tremer@ipfire.org
> To: blago.culjak@hotmail.com; development@lists.ipfire.org
> Date: Sat, 17 Oct 2015 12:51:36 +0100
>
> Hello,
>
> thanks for taking this opportunity this quickly.
>
> On Sat, 2015-10-17 at 08:44 +0200, Blago Culjak wrote:
> > Hello, Michael, I have taken-over bug,
> > https://bugzilla.ipfire.org/show_bug.cgi?id=10918, made changed, now
> > bug is gone on my test system.
> >
> > How should I send it to you guys for merge?
>
> Please follow this guide: http://wiki.ipfire.org/devel/submit-patches
>
> Feel free to ask questions if anything is not clear.
>
> > I have changed 54 line of
> > /srv/web/ipfire/html/themes/ipfire/include/js/refreshInetInfo.js and
> > it works fine, in kbits/mbits...
>
> There are also other themes, did you check these as well? There is also
> a short moment after a page is loaded when the JS is not executed, yet.
> I am just wondering if it says "kBit" there as well.
>
> >
> > Thank you for helping out a new guy.
>
> -Michael
>
> P.S. Please make sure to reply to the list as well.
>
> >
> >
> > > Subject: [ANNOUNCE] Good First Bugs
> > > From: michael.tremer@ipfire.org
> > > To: development@lists.ipfire.org
> > > Date: Fri, 16 Oct 2015 22:08:21 +0100
> > >
> > > Hello,
> > >
> > > as discussed at the IPFire Developer Summit 2015, we are now
> > > introducing "Good First Bugs". These are bugs tagged with the
> > keyword
> > > "GoodFirstBug" and recommended for beginners to solve.
> > >
> > > They should help us to encourage more people to start development
> > with
> > > IPFire and are tasks that should be resolvable in a reasonable
> > amount
> > > of time. They usually should not require knowledge in any advanced
> > > programming languages.
> > >
> > > http://wiki.ipfire.org/devel/bugzilla/good-first-bug
> > >
> > > These bugs can be found by searching for the keyword on Bugzilla:
> > >
> > > https://bugzilla.ipfire.org/buglist.cgi?keywords=GoodFirstBug
> > >
> > > This message is to all the developers who should tag appropriate
> > bugs
> > > as such, encourage people to take on a bug and mentor them if any
> > help
> > > is needed.
> > >
> > > There will also be a post on the IPFire planet release some time
> > next
> > > week to announce this to the people who are following our blog and
> > > other social media.
> > >
> > > http://planet.ipfire.org/post/good-first-bugs
> > >
> > > Best,
> > > -Michael