Should be:

Tested-by: Jon Murphy <jon.murphy@ipfire.org>


On May 30, 2022, at 1:55 PM, Peter Müller <peter.mueller@ipfire.org> wrote:

Hello Jon,

thanks for your mail. Apologies for my belated response.

Hi Peter,

I just tested "pcengines-apu-firmware: Update to version 4.16.0.3" with IPFire 2.27 (x86_64) - Core Update 168 Development Build: master/bbd4767f on an APU4d4 and the PCengines firmware installed A-OK.  I rebooted the APU and all works as expected:

# firmware-update info
Board       : PC Engines apu4
HW Version  : 1.0
Serial      : 123456
BIOS Version: v4.16.0.3 (04/21/2022)

Excellent! :-)

I found the Git Tags here:
https://wiki.ipfire.org/devel/git/tags#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

But besides manually typing "Tested-by: Jon . . . " and sending this email, I am really not sure how to "officially" reply.  Hope this made sense!

Yes, this reads a bit like stone-age tooling, but that is exactly the way to go.
I'll just add the tag for you (the < and > enclosure of the mail address is important).

Tested-by: Jon Murphy <jcmurphy26@gmail.com>

That should now appear in Patchwork properly.

All the best,
Peter Müller



Jon

On May 2, 2022, at 12:31 AM, Peter Müller <peter.mueller@ipfire.org> wrote:

Reviewed-by: Peter Müller <peter.mueller@ipfire.org>

- Update from 4.15.0.1 to 4.16.0.3
- Update of rootfile
- Changelog
 v4.16.0.3 - Release date: 2022-04-21
    Rebased with official coreboot repository commit 2c4b426557
    See: https://github.com/pcengines/coreboot/compare/v4.16.0.2...v4.16.0.3
 v4.16.0.2 - Release date: 2022-03-29
    Rebased with official coreboot repository commit 66f99f7fa7
    See: https://github.com/pcengines/coreboot/compare/v4.16.0.1...v4.16.0.2
 v4.16.0.1 - Release date: 2022-03-08
    Rebased with official coreboot repository commit b4ba289fa5
    Disabled loglevel prefixes introduced in coreboot 4.16
    Disabled ANSI escape sequences introduced in coreboot 4.16
    Fixed AMD PSP CCP as entropy source
 v4.15.0.3 - Release date: 2022-02-16
    Rebased with official coreboot repository commit 36425312ee
    Added checking hardware matrix before regression tests
    Fixed the hard disk not visible in the Seabios Boot Menu
 v4.15.0.2 - Release date: 2022-01-11
    rebased with official coreboot repository commit 3990da0b
    disabled SMM
    enabled parallel AP initialization for apu2-6 for faster boot time

Signed-off-by: Jon Murphy <jon.murphy@ipfire.org>
---
.../rootfiles/packages/pcengines-apu-firmware  | 12 ++++++------
lfs/pcengines-apu-firmware                     | 18 +++++++++---------
2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/config/rootfiles/packages/pcengines-apu-firmware b/config/rootfiles/packages/pcengines-apu-firmware
index de4f03efa..3811becf6 100644
--- a/config/rootfiles/packages/pcengines-apu-firmware
+++ b/config/rootfiles/packages/pcengines-apu-firmware
@@ -1,8 +1,8 @@
#lib/firmware/pcengines
#lib/firmware/pcengines/apu
-lib/firmware/pcengines/apu/apu1_v4.15.0.1.rom
-lib/firmware/pcengines/apu/apu2_v4.15.0.1.rom
-lib/firmware/pcengines/apu/apu3_v4.15.0.1.rom
-lib/firmware/pcengines/apu/apu4_v4.15.0.1.rom
-lib/firmware/pcengines/apu/apu5_v4.15.0.1.rom
-lib/firmware/pcengines/apu/apu6_v4.15.0.1.rom
+lib/firmware/pcengines/apu/apu1_v4.16.0.3.rom
+lib/firmware/pcengines/apu/apu2_v4.16.0.3.rom
+lib/firmware/pcengines/apu/apu3_v4.16.0.3.rom
+lib/firmware/pcengines/apu/apu4_v4.16.0.3.rom
+lib/firmware/pcengines/apu/apu5_v4.16.0.3.rom
+lib/firmware/pcengines/apu/apu6_v4.16.0.3.rom
diff --git a/lfs/pcengines-apu-firmware b/lfs/pcengines-apu-firmware
index d919675e8..9cc6c7e09 100644
--- a/lfs/pcengines-apu-firmware
+++ b/lfs/pcengines-apu-firmware
@@ -1,7 +1,7 @@
###############################################################################
#                                                                             #
# IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2021  IPFire Team  <info@ipfire.org>                     #
+# Copyright (C) 2007-2022  IPFire Team  <info@ipfire.org>                     #
#                                                                             #
# This program is free software: you can redistribute it and/or modify        #
# it under the terms of the GNU General Public License as published by        #
@@ -26,14 +26,14 @@ include Config

SUMMARY    = Firmware files for PC Engines apu system boards

-VER        = 4.15.0.1
+VER        = 4.16.0.3

THISAPP    = pcengines-apu-firmware-$(VER)
DL_FROM    = $(URL_IPFIRE)
DIR_APP    = $(DIR_SRC)/$(THISAPP)
TARGET     = $(DIR_INFO)/$(THISAPP)
PROG       = pcengines-apu-firmware
-PAK_VER    = 10
+PAK_VER    = 11
SUP_ARCH   = x86_64

DEPS       = firmware-update
@@ -59,12 +59,12 @@ apu4_v$(VER).rom = $(DL_FROM)/apu4_v$(VER).rom
apu5_v$(VER).rom = $(DL_FROM)/apu5_v$(VER).rom
apu6_v$(VER).rom = $(DL_FROM)/apu6_v$(VER).rom

-apu1_v$(VER).rom_BLAKE2 = 317bf51d82c1c99514d3dc3d6324e8f6c6b4768f2052902673a21fbdb554f6602940dbd531a80074a00ca9777d72bd8772deac5be2e4df38c8675e1d67d426ee
-apu2_v$(VER).rom_BLAKE2 = eaa5fa9bf1b0f1439b41cc2d48e0db24fb3e1096419ca728c98644d43a5bf0164380ab7173cbcbcf14b38052128c4b6c0bd8032e65f12c6f79262801fc534875
-apu3_v$(VER).rom_BLAKE2 = 11af9de100d7da62edd585c1327325cdd661eafc1e540f9395728ee47e35acf427348b29e011f5269e86ab6d6923f7e2a47b59cdf7d5a982cbe4328abc10652c
-apu4_v$(VER).rom_BLAKE2 = bf57beb63cd7581d6d3f24e2c6f51f15c540dc99036a2ccc22ecf9e3fbc8f37bf5bc46bb96fa9f854b952aa9a09130d7096f0a3c372b040cfcfc2abbf644c428
-apu5_v$(VER).rom_BLAKE2 = e296e2e168be85220f22e00d7cd075c73660f18ffb28b26a16c01129f77e2ed50148b3c95405945bcacdebf9d6e4e76ef08ffcef362898c46a381453844d9606
-apu6_v$(VER).rom_BLAKE2 = d6ce353299499be201af03ee678aa8bf3e33bdc2c9c952e91242b67febf9678bb85b6f6ed1b7d7b4278f5921cadb306451603d6c59bdf45d70793faf2c26312b
+apu1_v$(VER).rom_BLAKE2 = 3223d7ca35797a3e4eaea993fd93eeece842e46829cf3a39625ad3a3b5eceb241812b25198a94545f4de42b4bf2d31503746f08e9b361cff2d7ce11ec0ba24d9
+apu2_v$(VER).rom_BLAKE2 = 8d6ddb76189813546c3594ef9f92e341e99cbec8bb3df414589625815269b2fe0973a01185a35f0afe9dd16949ccaccc3d9bf3baee2de696450dfd17c96175d7
+apu3_v$(VER).rom_BLAKE2 = 64405157e7bfeca467b70fe4982a844763ed3b1c95d7aac75210cbb14e7e0de0a6c34708002a5be94344eaf96cd1d187ce03e8c0d0f8597048e70c7ab9fa6e14
+apu4_v$(VER).rom_BLAKE2 = 4a29d17b2040edc880aea277789cc6158b00c834dba110b2eda2692a1571d51e01cfdec361ca4acdcfc019e4ae904c55dafff18020e7d23eabec5037f4ca7369
+apu5_v$(VER).rom_BLAKE2 = db3b87945578a2a86b17d998e2fc316b654a78201b852804ae7067b92d22033817d5a77da3736d31ec54ef5d296ad38e735709a232e9e6cad9674e543306cff6
+apu6_v$(VER).rom_BLAKE2 = e9a8bd06658f7df4c09ad304145272419bef7022d0ac577b0f8777f75b90e020790cbfba9c6a2fd5abf52205901ec735b6e2fe52fa9d22040a12b13e0959fb65

install : $(TARGET)