Hi Benjamin

First of all thank you for your work and your interrrest to share it.

I've take a look at your work and there are a few questions about it.

Unfortunately this addon won't work because there are a few little syntax errors.
Please take a look. Github marked them red.

Is there a reason why you use Version 3.4.27 and not Version 3.9?

In the lfs-file you made a mistake with the DEPS. All dependencies you write down here are no ipfire addons so your addon won't install because the dependencies cannot fulfilled.

You use a group named "video". IPfire has no group with that name so please change it to an existing one, such as nobody.

I think all this wouldn't be a problem to you. ;-)

At last there is the important question: If we merge it who mantain and support it in the future?

- Daniel

You need a firewall?
Easy to use? Powerful? Modular? For free?

www.ipfire.org
An Open Source Firewall Solution 
Am 19.05.2014 00:55, schrieb Benjamin Hahn:

Hi everybody,

 

some time ago I started working on the tvheadend addon.

I finally managed to finish a pull request on github for my changes.

I uploaded the build scripts for the latest „stable“ version of tvheadend.

Can you advise if there is anything I should change?

 

I also have the scripts for the nightly version on my build system somewhere.

Is there any best practice to manage „different versions” of the same addon?

 

Regards Benjamin

 



_______________________________________________
Development mailing list
Development@lists.ipfire.org
http://lists.ipfire.org/mailman/listinfo/development




Diese E-Mail ist frei von Viren und Malware, denn der avast! Antivirus Schutz ist aktiv.