Hello,

On Mon, 2014-06-30 at 20:53 +0200, Stefan Schantl wrote:
> Hello Michael,
>
> I've coded some lines to support the ddns provider "enom.com" which has
> been requested on our bugtracker (#10588, #10567).
>
> Basic tests with some invalid data ( because I don't have an account
> there) have been performed and the errors have been triggered the
> correct exceptions.

Great, but you really need to test your code. If it is a free provider
go and register an account. If not, search for someone who has already
got an account and get them testing this for you.

> * While implementing the new ddns provider, I've moved the "parse_xml"
> function from the Namecheap provider to the DDNSProvider main class to
> allow reuse of the code and gain access to this function for additional
> providers which will be included in the future.

I really don't see why we would need that in the global class. You could
probably move that to a third class you pull in which then provides only
this function. A class can inherit from multiple classes at the same
time.

> * I also found some missing lines which accidently have been dropped
> while fixing merge conflicts.

I would need an extra commit with only that.

> You can find all changes here:
>
> http://git.ipfire.org/?p=people/stevee/ddns.git;a=commit;h=21d0fcb8335d979344a97e33cc36aa88d0fd67cb
>
> Please have a look on them and merge them to upstream.

Done that. See my remarks above.

-Michael

> A big thanks in advance,
>
> -Stefan
> > Hello,
> >
> > this is a post to update you all about the recent developments regarding
> > the support for the various upcoming dynamic DNS providers.
> >
> >
> > Rationale
> >
> > Some of the major dynamic DNS providers stopped their free services or
> > made them unusable so that people started searching for alternatives. In
> > IPFire 2, a script called setddns.pl [1] is responsible for updating the
> > dynamic DNS records. This script has grown over the last couple of
> > months and if you have looked into it you will have noticed that it has
> > become from ugly to almost un-maintainable. The decision that we don't
> > want to take this mess with us into the next generation of IPFire was
> > already made many years ago.
> >
> >
> > DDNS
> >
> > A project called ddns was started which is a pure Python client that is
> > much more flexible, cleanly rewritten and easily extensible. It is
> > cross-platform, cross-distribution and does not need any third-party
> > python modules.
> >
> > The basics already written years ago, Stefan Schantl and I worked on
> > making this ready for IPFire 2 and added all the providers that are
> > currently supported by setddns.pl and ez-ipupdate.
> >
> > The source for the new DDNS tool can be found over here:
> >
> >    http://git.ipfire.org/?p=ddns.git;a=summary
> >
> > or on GitHub
> >
> >    https://github.com/ipfire/ddns
> >
> > were you can send us pull requests for supporting new providers and so
> > on.
> >
> > Bug reports go to the usual place:
> >
> >    https://bugzilla.ipfire.org/describecomponents.cgi?product=DDNS%20Updater
> >
> > There is no fixed release schedule for this, but we are pretty sure that
> > this won't take long until DDNS arrives in IPFire 2. That means that we
> > won't take any patches for the setddns.pl script that add support for
> > new providers any more.
> >
> > We appreciate any contribution and as always hope to get some feedback
> > back from the community!
> >
> > Best,
> > -Michael
> >
> > [1] http://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=src/scripts/setddns.pl;h=5e77fce5c024a3f17ba4c892a94abfe95845e8c6;hb=HEAD
> >
> > _______________________________________________
> > Development mailing list
> > Development@lists.ipfire.org
> > http://lists.ipfire.org/mailman/listinfo/development
>
> _______________________________________________
> Development mailing list
> Development@lists.ipfire.org
> http://lists.ipfire.org/mailman/listinfo/development


_______________________________________________
Development mailing list
Development@lists.ipfire.org
http://lists.ipfire.org/mailman/listinfo/development