This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "IPFire 2.x development tree".
The branch, next has been updated via 8ed77b039fd0373fdc07ec79877caf34b8264cd2 (commit) from 0eba3dc448e17d49299781706ff1f44f51413f3f (commit)
Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.
- Log ----------------------------------------------------------------- commit 8ed77b039fd0373fdc07ec79877caf34b8264cd2 Author: Axel Gembe ago@multipixs.com Date: Mon Aug 11 12:23:58 2014 +0800
general-functions.pl: validdomainname misinterprets RFC1035
The function validdomainname checks that each part of a domain name is at least 2 characters in length, but RFC1035 only makes a restriction on a "label" being at most 63 characters in length. This change allows reverse DNS zones like 2.168.192.in-addr.arpa to be added to the DNS forward configuration, which was incorrectly prevented before.
Signed-off-by: Axel Gembe ago@multipixs.com
-----------------------------------------------------------------------
Summary of changes: config/cfgroot/general-functions.pl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Difference in files: diff --git a/config/cfgroot/general-functions.pl b/config/cfgroot/general-functions.pl index 66286ed..8ed87fc 100644 --- a/config/cfgroot/general-functions.pl +++ b/config/cfgroot/general-functions.pl @@ -627,9 +627,8 @@ sub validdomainname my @parts = split (/./, $domainname); # Split hostname at the '.'
foreach $part (@parts) { - # Each part should be at least two characters in length - # but no more than 63 characters - if (length ($part) < 2 || length ($part) > 63) { + # Each part should be no more than 63 characters in length + if (length ($part) < 1 || length ($part) > 63) { return 0;} # Only valid characters are a-z, A-Z, 0-9 and - if ($part !~ /^[a-zA-Z0-9-]*$/) {
hooks/post-receive -- IPFire 2.x development tree