This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "IPFire 2.x development tree".
The branch, master has been updated via c2f80e67a711eee43dd5c815defc689fc7604b64 (commit) from 5354d0f5c902f208d755b3b8a06f5896d4d2c975 (commit)
Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.
- Log ----------------------------------------------------------------- commit c2f80e67a711eee43dd5c815defc689fc7604b64 Author: Stefan Schantl stefan.schantl@ipfire.org Date: Tue Aug 5 21:24:44 2014 +0200
ddns.cgi: Fix enable/disable handling of entries.
When the "enabled" checkbox is checked a "on" will be returned, if the box is unchecked checkboxes will return nothing.
As a result of this behaviour the ddns.conf contained entries which have been disabled in the WUI.
We now check if the checkbox returns a "on", otherwise we will set the "enabled" value to "off" to prevent from this problem.
-----------------------------------------------------------------------
Summary of changes: html/cgi-bin/ddns.cgi | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
Difference in files: diff --git a/html/cgi-bin/ddns.cgi b/html/cgi-bin/ddns.cgi index 65e3bee..dc5dacc 100644 --- a/html/cgi-bin/ddns.cgi +++ b/html/cgi-bin/ddns.cgi @@ -197,6 +197,12 @@ if (($settings{'ACTION'} eq $Lang::tr{'add'}) || ($settings{'ACTION'} eq $Lang:: # Splitt hostname field into 2 parts for storrage. my($hostname, $domain) = split(/./, $settings{'HOSTNAME'}, 2);
+ # Handle enabled checkbox. When the checkbox is selected a "on" will be returned, + # if the checkbox is not checked nothing is returned in this case we set the value to "off". + if ($settings{'ENABLED'} ne 'on') { + $settings{'ENABLED'} = 'off'; + } + # Handle adding new accounts. if ($settings{'ACTION'} eq $Lang::tr{'add'}) {
@@ -215,8 +221,6 @@ if (($settings{'ACTION'} eq $Lang::tr{'add'}) || ($settings{'ACTION'} eq $Lang:: # Write out notice to logfile. &General::log($Lang::tr{'ddns hostname added'});
- # Update ddns config file. - # Handle account edditing. } elsif ($settings{'ACTION'} eq $Lang::tr{'update'}) {
@@ -354,7 +358,9 @@ $checked{'BEHINDROUTER'}{'RED_IP'} = ''; $checked{'BEHINDROUTER'}{'FETCH_IP'} = ''; $checked{'BEHINDROUTER'}{$settings{'BEHINDROUTER'}} = "checked='checked'";
-$checked{'ENABLED'}{'on'} = ($settings{'ENABLED'} eq '' ) ? '' : "checked='checked'"; +$checked{'ENABLED'}{'on'} = ''; +$checked{'ENABLED'}{'off'} = ''; +$checked{'ENABLED'}{$settings{'ENABLED'}} = "checked='checked'";
# Show box for errormessages.. if ($errormessage) { @@ -451,7 +457,7 @@ print <<END
<tr> <td class='base'>$Lang::tr{'enabled'}</td> - <td><input type='checkbox' name='ENABLED' value='on' $checked{'ENABLED'}{'on'} /></td> + <td><input type='checkbox' name='ENABLED' $checked{'ENABLED'}{'on'} /></td> <td class='base'>$Lang::tr{'username'}</td> <td><input type='text' name='LOGIN' value='$settings{'LOGIN'}' /></td> </tr>
hooks/post-receive -- IPFire 2.x development tree