From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sven To: ipfire-artwork@lists.ipfire.org Subject: Re: [IPFire Artwork] Website Date: Thu, 06 Apr 2017 15:19:32 +0200 Message-ID: <03067175-3A81-496C-85CE-0513D5EAE11D@posteo.de> In-Reply-To: <1491481180.2643.130.camel@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7716126621317161760==" List-Id: --===============7716126621317161760== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable > On 6. Apr 2017, at 14:19, Michael Tremer wrot= e: >=20 > First of all loads of thanks to you two for working on this. This is really > coming along looking awesome. >=20 > How do we fix the "visual bugs" now? Good question, >=20 > I am not really on the same page with what should be finished now and what = not. > Many pages look broken and I assume you just have not been working on these= , yet > :) I didn=E2=80=99t look at any other page except the homepage and to me it=E2= =80=99s not clear which page get a complete new layout and which page get onl= y the =E2=80=9Cstyle-update=E2=80=9D. >=20 > And I have some smaller things that don't seem to look right in Firefox. Is= this > the right time to collect these, yet? Yes. But let us open a ticket on the bug tracker for the webpage. I think that some of the things that don=E2=80=99t look right to you are the = same for Maurice. @Michael can you create the ticket? I=E2=80=99m not sure in which category it= goes. Thanks.=20 >=20 > -Michael >=20 > On Wed, 2017-04-05 at 23:02 +0200, Maurice Gesswein wrote: >> First output looks very promising for me. Thanks Sven! >>=20 >> It seems to be that something went weird with the colors at Zeplin. At the >> thumbnails they look good, when you open a screen they doesn't. Good news:= Hex >> codes are correct! :) I'll figure out what went wrong and perhaps I found >> another tool like Zeplin which can be archived by Michael ;p Stay tuned, s= till >> checking the feature set. >>=20 >> Next thing is that Zeplin interprets the properties of e.g. a font correct= but >> might be unclear for others. Please use the properties ABOVE the CSS box as >> the primary information about the selected element. Than your mentioned >> opacity issue should be clear. The colors should look like this: rgba(0, 0= , 0, >> 0.6). >>=20 >>=20 >> I found several things I would like to fix: >> I noticed that I have to build up the Sketch file in a different way that >> icons will be exported correct as 24x24px size. At the moment they are >> cropped. At their proper size of 24x24px it will be a lot easier to align >> those vertically correct. I'll update the Icon screen asap. >> Please recheck all opacity values. A lot of them are not correct. I guess >> that's due to the CSS output of Zeplin and how I set up the Sketch file. U= se >> the values which are shown above the CSS box. >> Please also recheck the line-heights of each font-style. Some of them has >> strange values. >> Font weight on buttons should be medium/600. >> Ghost buttons doesn't have dropshadows >> Lots of elements become smaller at <992px width. That should not happens. >> It seems to be that the gaps of the grid were not set to 24px instead of 3= 0px. >> Aren't they? If this would cause too much trouble, we can leave it as it i= s. >> It doesn't have a bad impact. >> "Fire" of IPFire in the top navigation is not bold/medium >> The buttons has lots of different heights. Please set a fixed height of 36= for >> default buttons and 48px for big buttons >> The touch target area is missing at the default buttons (48px height). Tha= t's >> important to provide a good user experience at touch devices. The clickable >> area must be big enough that fat finger hits it the first time ;) >> At viewport <992px the burger icon is not left aligned anymore. But you >> already said that you doesn't spend much time at the navigation so far. >> Some more minor issues... But for now it should be enough to fix :) >>=20 >> Do we want to set up a Trello board for all these and upcoming todos? I'm = also >> fine by using Git issues for that. >>=20 >> Best, >> Maurice >>=20 >> On Wed, Apr 5, 2017 at 8:02 PM, Sven wrote: >>> and now how we proceed? >>>=20 >>> Are you writing down a list with all the things to change? >>>=20 >>> Do we talk so that everybody express what he thinks and what to change? >>>=20 >>>=20 >>>> On 5. Apr 2017, at 19:55, Michael Tremer >>> wrote: >>>>=20 >>>> Hi, >>>>=20 >>>> it is all up on http://dev.ipfire.org >>>>=20 >>>> If you want to view fireinfo, just add the "dev" to the domain. For >>> example: >>>>=20 >>>> http://fireinfo.dev.ipfire.org >>>>=20 >>>> Do the same for planet, wishlist, etc... >>>>=20 >>>> -Michael >>>>=20 >>>> On Wed, 2017-04-05 at 18:11 +0100, Michael Tremer wrote: >>>>> Hi, >>>>>=20 >>>>> On Tue, 2017-04-04 at 22:18 +0200, Sven wrote: >>>>>>=20 >>>>>> Hello everybody, >>>>>> I=E2=80=99m thinkin=E2=80=99 that the coding of the home page has reac= hed a point where >>> we >>>>>> need the site live to discuss. >>>>>=20 >>>>> Great! >>>>>=20 >>>>>>=20 >>>>>> It=E2=80=99s not pixel perfect, the mobile menu is only the bootstrap = version >>> from >>>>>> top >>>>>> down and not from the left like in the mookups, the SCSS code is still >>> very >>>>>> chaotic, the image-scaling dosen=E2=80=99t work like expected and the = svg >>> scaling >>>>>> dosen=E2=80=99t work at all in Safari, but it=E2=80=99s good enough to= have a >>> conversation. >>>>>>=20 >>>>>> @Michael it is possible to include html markup between these brackets = {{ >>>>>> _("IPFire") }} for example {{ _(=E2=80=9CIPFire") }} >>>>>=20 >>>>> No. The translation function escapes all HTML. >>>>>=20 >>>>>>=20 >>>>>> @Maurice I have troubles with the colours, in zeplin for example the >>>>>> background is $blue_grey_900 but with a opacity of 0.6 when I put the >>> same >>>>>> values in my css the colour seems darker. >>>>>> But its easier to go all of these details when you see it in your >>> browser. >>>>>>=20 >>>>>> Greetings, >>>>>> Sven >>>>>=20 >>>>> -Michael >>>=20 >>>=20 --===============7716126621317161760==--