public inbox for ipfire-artwork@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: ipfire-artwork@lists.ipfire.org
Subject: Re: [IPFire Artwork] Website
Date: Thu, 06 Apr 2017 13:19:40 +0100	[thread overview]
Message-ID: <1491481180.2643.130.camel@ipfire.org> (raw)
In-Reply-To: <CAPxcDEt8GpdQg9e8rTr17V1Ro-kdgOjCB20NwUPrYrE6acn+kQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 5071 bytes --]

First of all loads of thanks to you two for working on this. This is really
coming along looking awesome.

How do we fix the "visual bugs" now?

I am not really on the same page with what should be finished now and what not.
Many pages look broken and I assume you just have not been working on these, yet
:)

And I have some smaller things that don't seem to look right in Firefox. Is this
the right time to collect these, yet?

-Michael

On Wed, 2017-04-05 at 23:02 +0200, Maurice Gesswein wrote:
> First output looks very promising for me. Thanks Sven!
> 
> It seems to be that something went weird with the colors at Zeplin. At the
> thumbnails they look good, when you open a screen they doesn't. Good news: Hex
> codes are correct! :) I'll figure out what went wrong and perhaps I found
> another tool like Zeplin which can be archived by Michael ;p Stay tuned, still
> checking the feature set.
> 
> Next thing is that Zeplin interprets the properties of e.g. a font correct but
> might be unclear for others. Please use the properties ABOVE the CSS box as
> the primary information about the selected element. Than your mentioned
> opacity issue should be clear. The colors should look like this: rgba(0, 0, 0,
> 0.6).
> 
> 
> I found several things I would like to fix:
> I noticed that I have to build up the Sketch file in a different way that
> icons will be exported correct as 24x24px size. At the moment they are
> cropped. At their proper size of 24x24px it will be a lot easier to align
> those vertically correct. I'll update the Icon screen asap.
> Please recheck all opacity values. A lot of them are not correct. I guess
> that's due to the CSS output of Zeplin and how I set up the Sketch file. Use
> the values which are shown above the CSS box.
> Please also recheck the line-heights of each font-style. Some of them has
> strange values.
> Font weight on buttons should be medium/600.
> Ghost buttons doesn't have dropshadows
> Lots of elements become smaller at <992px width. That should not happens.
> It seems to be that the gaps of the grid were not set to 24px instead of 30px.
> Aren't they? If this would cause too much trouble, we can leave it as it is.
> It doesn't have a bad impact.
> "Fire" of IPFire in the top navigation is not bold/medium
> The buttons has lots of different heights. Please set a fixed height of 36 for
> default buttons and 48px for big buttons
> The touch target area is missing at the default buttons (48px height). That's
> important to provide a good user experience at touch devices. The clickable
> area must be big enough that fat finger hits it the first time ;)
> At viewport <992px the burger icon is not left aligned anymore. But you
> already said that you doesn't spend much time at the navigation so far.
> Some more minor issues... But for now it should be enough to fix :)
> 
> Do we want to set up a Trello board for all these and upcoming todos? I'm also
> fine by using Git issues for that.
> 
> Best,
> Maurice
> 
> On Wed, Apr 5, 2017 at 8:02 PM, Sven <sven.hoehn(a)posteo.de> wrote:
> > and now how we proceed?
> > 
> > Are you writing down a list with all the things to change?
> > 
> > Do we talk so that everybody express what he thinks and what to change?
> > 
> > 
> > > On 5. Apr 2017, at 19:55, Michael Tremer <michael.tremer(a)ipfire.org>
> > wrote:
> > >
> > > Hi,
> > >
> > > it is all up on http://dev.ipfire.org
> > >
> > > If you want to view fireinfo, just add the "dev" to the domain. For
> > example:
> > >
> > >   http://fireinfo.dev.ipfire.org
> > >
> > > Do the same for planet, wishlist, etc...
> > >
> > > -Michael
> > >
> > > On Wed, 2017-04-05 at 18:11 +0100, Michael Tremer wrote:
> > >> Hi,
> > >>
> > >> On Tue, 2017-04-04 at 22:18 +0200, Sven wrote:
> > >>>
> > >>> Hello everybody,
> > >>> I’m thinkin’ that the coding of the home page has reached a point where
> > we
> > >>> need the site live to discuss.
> > >>
> > >> Great!
> > >>
> > >>>
> > >>> It’s not pixel perfect, the mobile menu is only the bootstrap version
> > from
> > >>> top
> > >>> down and not from the left like in the mookups, the SCSS code is still
> > very
> > >>> chaotic, the image-scaling dosen’t work like expected and the svg
> > scaling
> > >>> dosen’t work at all in Safari, but it’s good enough to have a
> > conversation.
> > >>>
> > >>> @Michael it is possible to include html markup between these brackets {{
> > >>> _("IPFire") }} for example {{ _(“IP<strong>Fire</strong>") }}
> > >>
> > >> No. The translation function escapes all HTML.
> > >>
> > >>>
> > >>> @Maurice I have troubles with the colours, in zeplin for example the
> > >>> background is $blue_grey_900 but with a opacity of 0.6 when I put the
> > same
> > >>> values in my css the colour seems darker.
> > >>> But its easier to go all of these details when you see it in your
> > browser.
> > >>>
> > >>> Greetings,
> > >>> Sven
> > >>
> > >> -Michael
> > 
> > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

       reply	other threads:[~2017-04-06 12:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAPxcDEt8GpdQg9e8rTr17V1Ro-kdgOjCB20NwUPrYrE6acn+kQ@mail.gmail.com>
2017-04-06 12:19 ` Michael Tremer [this message]
2017-04-06 13:19   ` Sven
     [not found] <CAPxcDEujG--kUAHx0_PKe5RF-iv2hG4nVyDMkfVFm0ni1M2DPg@mail.gmail.com>
2017-04-12 15:58 ` Michael Tremer
     [not found] <CAPxcDEu8x8906S+vKGcQ_wtU6ww_VwvWfEMN_g7-O3eddkkNnw@mail.gmail.com>
2017-04-11 14:27 ` Michael Tremer
     [not found] <66AFDE10-5F27-4D4A-BFE4-11770ED84F4D@posteo.de>
2017-04-11 10:26 ` Michael Tremer
     [not found] <CAPxcDEv2NUk_K6Fno-quS49EZv8ds6ewnxk6z_y-UnC6yw2paQ@mail.gmail.com>
2017-04-07 10:01 ` Michael Tremer
2017-04-07 14:40   ` Sven
     [not found] <5D23C26C-AE2E-4E2B-A6F1-E97B1746762F@posteo.de>
2017-04-06 12:15 ` Michael Tremer
2017-04-04 20:18 Sven
2017-04-05 17:11 ` Michael Tremer
2017-04-05 17:55   ` Michael Tremer
2017-04-05 18:02     ` Sven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491481180.2643.130.camel@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=ipfire-artwork@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox