public inbox for ipfire-scm@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <git@ipfire.org>
To: ipfire-scm@lists.ipfire.org
Subject: [git.ipfire.org] IPFire 2.x development tree branch, core194, created. 262809b881398c77f31d73a06f4b51461820fe85
Date: Wed,  7 May 2025 09:07:51 +0000 (UTC)	[thread overview]
Message-ID: <4ZsqD70L9kz2xKQ@people01.haj.ipfire.org> (raw)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "IPFire 2.x development tree".

The branch, core194 has been created
        at  262809b881398c77f31d73a06f4b51461820fe85 (commit)

- Log -----------------------------------------------------------------
commit 262809b881398c77f31d73a06f4b51461820fe85
Author: Adolf Belka <adolf.belka@ipfire.org>
Date:   Thu May 1 09:41:03 2025 +0200

    core194: Fix cert name and change other check to ! -s
    
    - This v2 version corrects the b! -z to ! -s
    - Error in hostcert extension
    - -z is for use with strings and not with files. This should have been ! -s. Thanks to
       @Nick for spotting this and flagging it up. Th ! -z would do the test against the
       filename string and as this doesn't change then it would always come up true.
    - I thought I had tested the original patch of this change but obviously not because
       there was missing whitespace and filenames not quoted plus the fixes I have added
       in this patch.
    - I definitely tested this out this time by copying it from the update.sh and applying
       it to my vm system. I have also tested this out with the hostcert.pem file present
       and not and with the index.txt file empty and containing something. This now works
       as it should, which is to only carry out the edit on the serial file if the
       hostcert.pem file is present AND the index.txt file is empty.
    - I clearly need to look more carefully at and test even more carefully at any bash
       statements that I put together.
    
    Tested-by: Adolf Belka <adolf.belka@ipfire.org>
    Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
    Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

-----------------------------------------------------------------------


hooks/post-receive
--
IPFire 2.x development tree


                 reply	other threads:[~2025-05-07  9:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ZsqD70L9kz2xKQ@people01.haj.ipfire.org \
    --to=git@ipfire.org \
    --cc=ipfire-scm@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox