[git.ipfire.org] IPFire 2.x development tree branch, core195, updated. 9f082ddca54f4e44667cbb83171f2bf764633347

[git.ipfire.org] IPFire 2.x development tree branch, core195, updated. 9f082ddca54f4e44667cbb83171f2bf764633347

[Michael Tremer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "IPFire 2.x development tree".

The branch, core195 has been updated
       via  9f082ddca54f4e44667cbb83171f2bf764633347 (commit)
      from  27ec6f7860da27d046ddeb33809eba897b0766e7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9f082ddca54f4e44667cbb83171f2bf764633347
Author: Michael Tremer <michael.tremer@ipfire.org>
Date:   Wed Jun 25 15:22:32 2025 +0100

    firewall.cgi: Remove some left-over debugging code
    
    This code prevented that any firewall rules could have been created due
    to the WUI always assuming that there would be some error.
    
    Fixes: #13860 - Error message when creating a firewall rule with a subnet for src
    Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

-----------------------------------------------------------------------

Summary of changes:
 html/cgi-bin/firewall.cgi | 6 ------
 1 file changed, 6 deletions(-)

Difference in files:
diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
index 855be095d..5f1eac09e 100644
--- a/html/cgi-bin/firewall.cgi
+++ b/html/cgi-bin/firewall.cgi
@@ -876,12 +876,6 @@ sub checkrule
 					$hint.=$Lang::tr{'fwdfw hint ip2'}." Source: $networkip1/$scidr Target: $networkip2/$tcidr<br>";
 				}
 		}else{
-			$errormessage .= $sip;
-			$errormessage .= $scidr;
-
-			$errormessage .= $tip;
-			$errormessage .= $tcidr;
-
 			if ( &General::IpInSubnet($networkip2,$sip,&General::iporsubtodec($scidr)) ){
 			$errormessage.=$Lang::tr{'fwdfw err samesub'} . $fwdfwsettings{'grp1'} .$fwdfwsettings{$fwdfwsettings{'grp1'}} . $fwdfwsettings{'grp2'} . $fwdfwsettings{$fwdfwsettings{'grp2'}};
 			}


hooks/post-receive
--
IPFire 2.x development tree