From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4bS3xY1vWBz32vw for ; Wed, 25 Jun 2025 14:25:05 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature RSA-PSS (4096 bits)) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4bS3xY1nwyz2y7D for ; Wed, 25 Jun 2025 14:25:05 +0000 (UTC) Received: from people01.haj.ipfire.org (people01.haj.ipfire.org [172.28.1.161]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature ECDSA (secp384r1)) (Client CN "people01.haj.ipfire.org", Issuer "E6" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4bS3xX6RJVz2SR for ; Wed, 25 Jun 2025 14:25:04 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1750861504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=ePrNz0mD7Pj3f260s5aj8P8FP7T7WNAQar7838wbtZA=; b=gblOm91Zl4oHcISBltmNrx26oV2Rljr7XBCg7ZTTdBnBUUEIWzBx2jrBSTpOHri6SKN0Xl TtGT4JzAxb17HCBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1750861504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=ePrNz0mD7Pj3f260s5aj8P8FP7T7WNAQar7838wbtZA=; b=OxQOmIY5dMK8Kxd9SUajZ1ZssDOPCgL3u88SGtvQzDPddQQDfQIe6nMUYG5MvCA2mmJhBW kuwhaYi7EvHUM9lBcdxbhwSIMH8I1QT8Y+3jk0PHyrIO80wHtBxb9jPC/zNZ/ODhYCxMSN Mq8yHnUSxD7+hiqr3qY++RbAL7g4JrgrLIgwcPltahI+14GcDn5pjm3jAMXiylfDtgvCrg mFxyyCR6m3qPR3172uiYELIf0RouASdeF4PEuE7Xl3rfb46geAfUVP6FYYIF5I4aHLdpz2 v9UdMOGeWWSdoOUAxxE1uEUH6gvuYeIJTiM+q+yhi1BNiaJ8lysZGnz3ocDZRA== Received: by people01.haj.ipfire.org (Postfix, from userid 1000) id 4bS3xX62GXz2xfL; Wed, 25 Jun 2025 14:25:04 +0000 (UTC) To: ipfire-scm@lists.ipfire.org Subject: [git.ipfire.org] IPFire 2.x development tree branch, core195, updated. 9f082ddca54f4e44667cbb83171f2bf764633347 X-Git-Refname: refs/heads/core195 X-Git-Reftype: branch X-Git-Oldrev: 27ec6f7860da27d046ddeb33809eba897b0766e7 X-Git-Newrev: 9f082ddca54f4e44667cbb83171f2bf764633347 Message-Id: <4bS3xX62GXz2xfL@people01.haj.ipfire.org> Date: Wed, 25 Jun 2025 14:25:04 +0000 (UTC) From: Michael Tremer Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "IPFire 2.x development tree". The branch, core195 has been updated via 9f082ddca54f4e44667cbb83171f2bf764633347 (commit) from 27ec6f7860da27d046ddeb33809eba897b0766e7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9f082ddca54f4e44667cbb83171f2bf764633347 Author: Michael Tremer Date: Wed Jun 25 15:22:32 2025 +0100 firewall.cgi: Remove some left-over debugging code This code prevented that any firewall rules could have been created due to the WUI always assuming that there would be some error. Fixes: #13860 - Error message when creating a firewall rule with a subnet for src Signed-off-by: Michael Tremer ----------------------------------------------------------------------- Summary of changes: html/cgi-bin/firewall.cgi | 6 ------ 1 file changed, 6 deletions(-) Difference in files: diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi index 855be095d..5f1eac09e 100644 --- a/html/cgi-bin/firewall.cgi +++ b/html/cgi-bin/firewall.cgi @@ -876,12 +876,6 @@ sub checkrule $hint.=$Lang::tr{'fwdfw hint ip2'}." Source: $networkip1/$scidr Target: $networkip2/$tcidr
"; } }else{ - $errormessage .= $sip; - $errormessage .= $scidr; - - $errormessage .= $tip; - $errormessage .= $tcidr; - if ( &General::IpInSubnet($networkip2,$sip,&General::iporsubtodec($scidr)) ){ $errormessage.=$Lang::tr{'fwdfw err samesub'} . $fwdfwsettings{'grp1'} .$fwdfwsettings{$fwdfwsettings{'grp1'}} . $fwdfwsettings{'grp2'} . $fwdfwsettings{$fwdfwsettings{'grp2'}}; } hooks/post-receive -- IPFire 2.x development tree