From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: location@lists.ipfire.org Subject: Re: Countries nomenclature database Date: Fri, 21 Aug 2020 10:25:27 +0100 Message-ID: <0178B03F-88DB-4641-B326-3A9C529694A0@ipfire.org> In-Reply-To: =?utf-8?q?=3CVT0YIecoH7Uq2RoA6LoZf9ly-ms9=5FQhdb=5F8LiwINCyC7DG?= =?utf-8?q?VtJ1AZ8ProczJ6IeUc02g1bGPyJPtddibujPig9n4qoxz1TkU4UYL6C1mYjO8=3D?= =?utf-8?q?=40protonmail=2Ecom=3E?= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6892700309338639342==" List-Id: --===============6892700309338639342== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Pierre, Thank you for your email. > On 21 Aug 2020, at 02:42, Pierre Equoy wrot= e: >=20 > Hello, >=20 > I recently discovered the IPFire Location project[1] and I like that there = is an open alternative to Maxmind GeoIP database. It is great that you are interested in our little project. > I live in Taiwan, and when I connected on the website[1], I was greeted wit= h: >=20 > "You are visiting from Taiwan, Province of China" >=20 > I am indeed visiting from Taiwan, but Taiwan is not a province of China. I am aware of the difficulties around Taiwan. We addressed this during development of our database and first hoped that we = would not have to deal with this problem at all. We are touching political te= rritory and other countries and places in the world are also affected. I am p= ersonally not educated enough about all the individual issues and therefore u= nwilling to make a decision in either way. It will probably in the end come d= own to where you are, where you are from and what you believe in. So, we used the country list from a python module called =E2=80=9Ciso3166=E2= =80=9D which simply lists all countries known to that ISO standard with the s= ame number. In short: We wanted to outsource it. We realised very quickly that this won=E2=80=99t really reflect reality. Therefore we added a list of countries to the database and we added a name to= them for those who struggle to remember all the country codes (i.e. me). So here is the code that is pulling the country name from the python module w= hich is used and shown to you on the website: https://git.ipfire.org/?p=3Dipfire.org.git;a=3Dblob;f=3Dsrc/backend/countri= es.py;h=3D782c3fe1e6738c879074add52389c1624834d7c5;hb=3DHEAD We added a text file with the country code, continent code, and country name = to the database here: https://git.ipfire.org/?p=3Dlocation/location-database.git;a=3Dblob;f=3Dcou= ntries.txt;h=3Dced8aa9119f795480bab19179ac68227d7e3fe65;hb=3DHEAD That way we thought that it is easier to change and would give us more flexib= ility as well as some consistency wherever libloc is being used. However, our= own application does not use that. Note that Taiwan is simply =E2=80=9CTaiwan=E2=80=9D here. So, I will change our web app and have it pull the country name from the data= base. I apologise for any trouble this has caused and I thank you very much for hig= hlighting this issue. If there are any others we are currently not aware of, = please get in touch. Best, -Michael > I had a look at the source code[2] but couldn't find the database you are u= sing in order to provide a patch. >=20 > Is it possible to modify the wording? >=20 > Thanks, >=20 >=20 > [1] https://location.ipfire.org/ > [2] https://git.ipfire.org/?p=3Dlocation/libloc.git;a=3Dsummary >=20 > -- > Pierre >=20 > Sent with ProtonMail Secure Email. >=20 >=20 --===============6892700309338639342==--