From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: [PATCH] perl: Add function to perform AS number lookups.
Date: Tue, 01 Oct 2019 12:59:08 +0100
Message-ID: <01A57A3D-1A91-4FE2-B966-90C7AAC0CEB5@ipfire.org>
In-Reply-To: <20191001061651.4737-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7763111216264544942=="
List-Id: <location.lists.ipfire.org>

--===============7763111216264544942==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable



> On 1 Oct 2019, at 07:16, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> src/perl/Location.xs | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>=20
> diff --git a/src/perl/Location.xs b/src/perl/Location.xs
> index ab27f0b..63410c4 100644
> --- a/src/perl/Location.xs
> +++ b/src/perl/Location.xs
> @@ -117,6 +117,32 @@ lookup_country_code(db, address)
> 	OUTPUT:
> 		RETVAL
>=20
> +unsigned int
> +lookup_asn(db, address)
> +	struct loc_database* db;
> +	char* address;
> +
> +	CODE:
> +		// Lookup network
> +		struct loc_network *network;

I like to initialise variables like this with NULL.

Not sure if that is only considered style.

> +		int err =3D loc_database_lookup_from_string(db, address, &network);
> +		if (err) {
> +			croak("Could not look up for %s\n", address);
> +		}
> +
> +		// Extract the ASN
> +		unsigned int as_number =3D loc_network_get_asn(network);
> +		loc_network_unref(network);
> +
> +		if (as_number) {
> +			RETVAL =3D as_number;
> +		} else {
> +			//RETVAL =3D NULL;
> +			RETVAL =3D 0;
> +		}

So either you just put the return value of loc_network_get_asn into RETVAL, o=
r you use NULL.

I would prefer NULL here, because 0 is a reserved ASN. Will most likely never=
 be used, but we should follow the RFCs here.

-Michael

> +	OUTPUT:
> +		RETVAL
> +
> void
> DESTROY(db)
> 	struct loc_database* db;
> --=20
> 2.20.1
>=20


--===============7763111216264544942==--