Re: [0.9.12] export --format xt_geoip: (25, 'Inappropriate ioctl for device')

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

Hello Valters,

Here is the fix:

  https://git.ipfire.org/?p=location/libloc.git;a=commitdiff;h=47b55e7060f6714889d2a8a45dd01e3452e2db38

The error was shown incorrectly because this was the last syscall that failed (but it was executed by Python and not us).

The real reason is that the wrong prefix was used for IPv4 addresses which resulted in a sanity check failing. However, I did not catch that very well because it is incredibly unlikely to fail.

Please confirm to me whether or not this patch resolves the problem.

I was also going to ask on this list whether people would rely on support for xt_geoip. IPFire has just replaced xt_geoip with ipset and so we don’t need the code any more which is probably why I didn’t catch this problem earlier - I have added a small test though. Writing more tests, better development documentation and returning better error codes in some places is on our TODO list, but we are incredibly lacking time and human resources to allocate to this. Can you help?

-Michael

> On 29 Mar 2022, at 16:03, Michael Tremer <michael.tremer(a)ipfire.org> wrote:
> 
> Hello Valters,
> 
> Yes I can reproduce this on Debian 11 with the latest build from the Debian repository.
> 
> -Michael
> 
>> On 29 Mar 2022, at 15:43, Valters Jansons <valter.jansons(a)gmail.com> wrote:
>> 
>> I am wondering if maybe it has been broken previously but we never picked it up. Say, from ce1e53c "export: Sightly refactor export logic" in some magical case.
>> 
>> Michael, in any case, can you repro what I am seeing on the current release?
>> 
>> -Valters
>