From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: location@lists.ipfire.org Subject: Re: Countries nomenclature database Date: Fri, 21 Aug 2020 10:39:04 +0100 Message-ID: <0E841F2E-83E1-4841-905B-86F79D5945E5@ipfire.org> In-Reply-To: <0178B03F-88DB-4641-B326-3A9C529694A0@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3236730909194749264==" List-Id: --===============3236730909194749264== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Pierre, I have made the changes and I rolled them out: https://git.ipfire.org/?p=3Dipfire.org.git;a=3Dcommitdiff;h=3De929ed926c54b= d10e9387755b66add47795e6e50 Could you please check for me if you are seeing the correct country name now? Best, -Michael > On 21 Aug 2020, at 10:25, Michael Tremer wrot= e: >=20 > Hello Pierre, >=20 > Thank you for your email. >=20 >> On 21 Aug 2020, at 02:42, Pierre Equoy wro= te: >>=20 >> Hello, >>=20 >> I recently discovered the IPFire Location project[1] and I like that there= is an open alternative to Maxmind GeoIP database. >=20 > It is great that you are interested in our little project. >=20 >> I live in Taiwan, and when I connected on the website[1], I was greeted wi= th: >>=20 >> "You are visiting from Taiwan, Province of China" >>=20 >> I am indeed visiting from Taiwan, but Taiwan is not a province of China. >=20 > I am aware of the difficulties around Taiwan. >=20 > We addressed this during development of our database and first hoped that w= e would not have to deal with this problem at all. We are touching political = territory and other countries and places in the world are also affected. I am= personally not educated enough about all the individual issues and therefore= unwilling to make a decision in either way. It will probably in the end come= down to where you are, where you are from and what you believe in. >=20 > So, we used the country list from a python module called =E2=80=9Ciso3166= =E2=80=9D which simply lists all countries known to that ISO standard with th= e same number. In short: We wanted to outsource it. >=20 > We realised very quickly that this won=E2=80=99t really reflect reality. >=20 > Therefore we added a list of countries to the database and we added a name = to them for those who struggle to remember all the country codes (i.e. me). >=20 > So here is the code that is pulling the country name from the python module= which is used and shown to you on the website: >=20 > https://git.ipfire.org/?p=3Dipfire.org.git;a=3Dblob;f=3Dsrc/backend/countr= ies.py;h=3D782c3fe1e6738c879074add52389c1624834d7c5;hb=3DHEAD >=20 > We added a text file with the country code, continent code, and country nam= e to the database here: >=20 > https://git.ipfire.org/?p=3Dlocation/location-database.git;a=3Dblob;f=3Dco= untries.txt;h=3Dced8aa9119f795480bab19179ac68227d7e3fe65;hb=3DHEAD >=20 > That way we thought that it is easier to change and would give us more flex= ibility as well as some consistency wherever libloc is being used. However, o= ur own application does not use that. >=20 > Note that Taiwan is simply =E2=80=9CTaiwan=E2=80=9D here. >=20 > So, I will change our web app and have it pull the country name from the da= tabase. >=20 > I apologise for any trouble this has caused and I thank you very much for h= ighlighting this issue. If there are any others we are currently not aware of= , please get in touch. >=20 > Best, > -Michael >=20 >> I had a look at the source code[2] but couldn't find the database you are = using in order to provide a patch. >>=20 >> Is it possible to modify the wording? >>=20 >> Thanks, >>=20 >>=20 >> [1] https://location.ipfire.org/ >> [2] https://git.ipfire.org/?p=3Dlocation/libloc.git;a=3Dsummary >>=20 >> -- >> Pierre >>=20 >> Sent with ProtonMail Secure Email. >>=20 >>=20 >=20 --===============3236730909194749264==--