From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: location@lists.ipfire.org Subject: [PATCH v3 1/2] location-importer: Introduce auxiliary function to sanitise ASNs Date: Sat, 23 Oct 2021 09:15:12 +0200 Message-ID: <12557f79-b0e0-04f1-99ed-3571eb7c68af@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2983657161449600232==" List-Id: --===============2983657161449600232== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The second version of this patch does this in a more Pythonic way. Signed-off-by: Peter M=C3=BCller --- src/python/location-importer.in | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/python/location-importer.in b/src/python/location-importer.in index da058d3..3ad335f 100644 --- a/src/python/location-importer.in +++ b/src/python/location-importer.in @@ -574,6 +574,21 @@ class CLI(object): # be suitable for libloc consumption... return True =20 + def _check_parsed_asn(self, asn): + """ + Assistive function to filter Autonomous System Numbers not being suitable + for adding to our database. Returns False in such cases, and True otherwi= se. + """ + + validranges =3D ((1,23455), (23457,64495), (131072, 4199999999)) + + for singlerange in validranges: + if singlerange[0] <=3D asn and singlerange[1] >=3D asn: + return True + + log.info("Supplied ASN %s out of publicly routable ASN ranges" % asn) + return False + def _parse_block(self, block, source_key, validcountries =3D None): # Get first line to find out what type of block this is line =3D block[0] @@ -829,8 +844,8 @@ class CLI(object): log.debug("Skipping ARIN AS names line not containing an integer for AS= N") continue =20 - if not ((1 <=3D asn and asn <=3D 23455) or (23457 <=3D asn and asn <=3D = 64495) or (131072 <=3D asn and asn <=3D 4199999999)): - log.debug("Skipping ARIN AS names line not containing a valid ASN: %s" = % asn) + # Filter invalid ASNs... + if not self._check_parsed_asn(asn): continue =20 # Skip any AS name that appears to be a placeholder for a different RIR = or entity... --=20 2.26.2 --===============2983657161449600232==--