public inbox for location@lists.ipfire.org
 help / color / mirror / Atom feed
From: Gisle Vanem <gisle.vanem@gmail.com>
To: location@lists.ipfire.org
Subject: Re: Problem with 'loc_as_get_name()'
Date: Wed, 28 Oct 2020 12:50:29 +0100	[thread overview]
Message-ID: <1d219de2-a69b-9b08-9f0c-af12da4438ad@gmail.com> (raw)
In-Reply-To: <A10A8B0E-A291-416A-8E24-D70AF98DE9E4@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

Michael Tremer wrote:

> It would be great if we could work on upstreaming your changes for
> Windows so that they become available for everyone and you no longer need to
> bundle your own version of libloc without receiving bugfixes from upstream.

Hi again. Sorry for the delay.

That would be tricky for me; I'm a n00b when it comes
to Git and pull-requests. But my my Win-sources are under
here:
   https://github.com/gvanem/wsock-trace/tree/master/src/Geo-IP/IPFire/libloc/src

You could perhaps pull them, create a diff and then
email me privately to discuss things if you really
want Windows support. It would be nice to see Location
get a much wider audience (competing with MaxMind and
IP2Location ...)

PS. One thing I see now, trying to support Cygwin too;
Your calls to 'mmap()' fails on Cygwin32 for a reason
I fail to understand; errno = EINVAL. So I use my
Win-mmap emulation for Cygwin too. Works fine.
Will see about Cygwin64.

-- 
--gv

  reply	other threads:[~2020-10-28 11:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b63ffe0e-6eca-7168-bb13-07281eff208f@gmail.com>
2020-10-22 10:17 ` What generates database.db from database.txt? Michael Tremer
2020-10-22 13:39 ` Problem with 'loc_as_get_name()' Gisle Vanem
2020-10-23  9:49   ` Michael Tremer
2020-10-23 16:29     ` Gisle Vanem
2020-10-23 17:27       ` Michael Tremer
2020-10-28 11:50         ` Gisle Vanem [this message]
2020-10-28 11:54           ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d219de2-a69b-9b08-9f0c-af12da4438ad@gmail.com \
    --to=gisle.vanem@gmail.com \
    --cc=location@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox