From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: [PATCH 03/10] importer: Just fetch any exception from the executor
Date: Tue, 27 Sep 2022 16:48:40 +0000 [thread overview]
Message-ID: <20220927164847.3409646-3-michael.tremer@ipfire.org> (raw)
In-Reply-To: <20220927164847.3409646-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
Any exceptions will only be raised in the main thread when they are
fetched from the executor. We do not need to print any other return
values here.
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
src/scripts/location-importer.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/scripts/location-importer.in b/src/scripts/location-importer.in
index ddec376..014f3b6 100644
--- a/src/scripts/location-importer.in
+++ b/src/scripts/location-importer.in
@@ -1297,8 +1297,9 @@ class CLI(object):
with concurrent.futures.ThreadPoolExecutor(max_workers=10) as executor:
results = executor.map(self._fetch_geofeed, geofeeds)
+ # Fetch all results to raise any exceptions
for result in results:
- print(result)
+ pass
def _fetch_geofeed(self, geofeed):
log.debug("Fetching Geofeed %s" % geofeed.url)
--
2.30.2
next prev parent reply other threads:[~2022-09-27 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 16:48 [PATCH 01/10] importer: Store geofeed URLs from RIR data Michael Tremer
2022-09-27 16:48 ` [PATCH 02/10] importer: Add command to import geofeeds into the database Michael Tremer
2022-09-27 16:48 ` Michael Tremer [this message]
2022-09-27 16:48 ` [PATCH 04/10] importer: Sync geofeeds Michael Tremer
2022-09-27 16:48 ` [PATCH 05/10] importer: Use geofeeds for country assignment Michael Tremer
2022-09-27 16:48 ` [PATCH 06/10] importer: Use a GIST index for networks from geofeeds Michael Tremer
2022-09-27 16:48 ` [PATCH 07/10] importer: Add a search index match geofeed networks quicker Michael Tremer
2022-09-27 16:48 ` [PATCH 08/10] importer: Fix reading Geofeeds from remarks Michael Tremer
2022-09-27 16:48 ` [PATCH 09/10] importer: Ensure that we only use HTTPS URLs for Geofeeds Michael Tremer
2022-09-27 16:48 ` [PATCH 10/10] importer: Validate country codes from Geofeeds Michael Tremer
2022-10-28 20:29 ` [PATCH 01/10] importer: Store geofeed URLs from RIR data Peter Müller
2022-10-29 11:43 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927164847.3409646-3-michael.tremer@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox