From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4ZWBTX6Vdyz30Hh for ; Mon, 7 Apr 2025 01:29:52 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature RSA-PSS (4096 bits)) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4ZWBTX015fz2ykN for ; Mon, 7 Apr 2025 01:29:52 +0000 (UTC) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4ZWBTV44NnzQt for ; Mon, 7 Apr 2025 01:29:50 +0000 (UTC) Authentication-Results: mail01.ipfire.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=ekeMj6NH; spf=pass (mail01.ipfire.org: domain of valter.jansons@gmail.com designates 2a00:1450:4864:20::129 as permitted sender) smtp.mailfrom=valter.jansons@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1743989391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:dkim-signature; bh=hvx0ZMVCdrKbuKYdzy4LafRnO8x5IVi3e+rxTjFc8vM=; b=WD649yhXIIv6yrIlbIRvpprwYYXpBunuGGWQ4JFCaLdS3cJqXklDZDiM9Sqy+PdOM7sdcX XLh+3Ogyjayqnp43dip+k45e2MfnXEdUPBaYNiCDvWrjHhzJM5p7J7Vks5DdQPg+15CdjX IwDzpGsWk9oKPfLDPhMOYLP/LK+OC7RTo8xwGQjozvu5jdc+Eneob8lJSLDaykq7oz6qNX tCaWNkt0ZS8qjolSrvIVMycO50b8WuqlgFvLmWZBSj/9H7BoQuySeNX8Pe1yh4oSXhqepA r0HXpnaKlAdunMGxlbGzF+TwaDYp7Be3okNjbRJoZFQp1tS0sIGyXmULSAm05A== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=ekeMj6NH; spf=pass (mail01.ipfire.org: domain of valter.jansons@gmail.com designates 2a00:1450:4864:20::129 as permitted sender) smtp.mailfrom=valter.jansons@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1743989391; a=rsa-sha256; cv=none; b=utnjGCADhdrY34M42EgQWyVuVmPRTkkLoGH82YwHMUG42IPmBZw5rAwjHMfb2fNiwa8umy cSzv+P/dcENG1rXMbk1YP54e5f4l2JQM46hqbdrmqj51Rde5idSP4fCH/PVFyBsF8M4O7O ix/m99m1CR+CsUc9aoXcfABdRy5e7QwiPuakunZPBr7OrAvib3VpAwxrW159BICHt8qptu Qs4YWxeaoMuHOV208t+8R08eAMNE7sAYPn6KVVBSwhh2qSd8Gp7E4lN5tIkWVjsr5dl2Ts yQwIY55JugZUwhRyDluH5bKeblGGSBMyD9n3gZ9T8AQKG8rJbKvdai78t4ISDg== Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-5499659e669so3985702e87.3 for ; Sun, 06 Apr 2025 18:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743989389; x=1744594189; darn=lists.ipfire.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=hvx0ZMVCdrKbuKYdzy4LafRnO8x5IVi3e+rxTjFc8vM=; b=ekeMj6NHSoBCqd3DDYwrM345SY89wUlQuROp/NHPllXxZh21CYu5v0WR+SA640smS4 +G75hrO3rjTO7n/q20ylWem/9cmikLYjrlWZ1btectP8Sf3/QmF8Vyt2YCImOEs5IgEN nc8TB2uR94iOFqMVeuHz5pruFdJjJ3UqqEPMMVB6GEM/mn+LH7CHacUeTLZEk74czcyb S5UNNzLbiKYHedDZ+2k8QCbpY+kiJvpzzSHAbU8ZcnOGeF6xUIWTyhZ9nQXE42vyQJuQ bUsmZ5bgbT52HvBd2NJa0UYSZZoBORXKvwuc3ws5oW9b1fOAGY/l1oGRR17T39xvtjmk LI9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743989389; x=1744594189; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hvx0ZMVCdrKbuKYdzy4LafRnO8x5IVi3e+rxTjFc8vM=; b=l4y6+hKR+skL+Qr3zqhA1rQZGLmTFF8uQpNW6TZO7tVtgiR/FZ1y6XCtEq4vrt/9Lj NLi4TB5Ms0W4qoE45gMgEtFMsyG2SxcpfJGjAYqGbYgHvzE39zl1tvps1eidV4E39Sac Q56uHo2ypoSAK2YtKIXc9mS5PGXIHk+5l9/m2mBh4M6q+L+hzdxjnImstLVlxw2WcNF5 fZUTXJyiXzCvImkAmgyD5a2f54iDgqhMIqVIOjki96xezojww9jXrRhYgqinJig9VijQ UuV1XRzpD2ry6NFAuTIGG3oZaYnmck1QKGHzTh2wRJzD9jqzPSAKd1Bps74RXqQ+zD2l +r6A== X-Gm-Message-State: AOJu0Yzxk+3KueoNJvhoU6iFjQM6ftIt1q+jJe+TaSET9/T/CVHVAZJR da3Gieq2eg4gUrr1zHmCyLQ/4NCjYRGTyugEh+cMGWKoJXePSwvrSp43nA== X-Gm-Gg: ASbGncuxlQ/GCTyCTvfemcMwMf0ZtUXEbjWR47v1nWBim11dvfISIuwB6DdwehHlFSD QAOCZ+1qYnFybdpFJ0qIfY/vYOUCQCYoYEguMEdUhTfTowV1RVAsE1g/fyaPqMJrdut7ajRBOzw R/6f7kOygxTiVYJoxYRk1JlYn6lcTLWTK3fEBrmuOokAV3VwCxCrECGKTQPDa8MSwwpyhGYq7fL wOodTFS4x+WtAHizpifjBJAVyYY72EyBn1jrffBKO5WGWkIcJOPLvBvcvD8XCaTCwker3qcbhXu tU9afwQiM20cDAbsay2HMeOv/U9EyGX/QaWZ2IBcQ85Vvhc= X-Google-Smtp-Source: AGHT+IEua/dxa3Dfg21e+vpmnLXAGp+w335tv8xeqteCcQuQuPo+wKJUQmwh11WnekEwHDRqoJnQrw== X-Received: by 2002:a05:6512:b05:b0:549:6451:7ea0 with SMTP id 2adb3069b0e04-54c22786028mr2588838e87.19.1743989388504; Sun, 06 Apr 2025 18:29:48 -0700 (PDT) Received: from V-T460.. ([185.65.163.128]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54c1e635bf7sm1137366e87.137.2025.04.06.18.29.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 18:29:46 -0700 (PDT) From: Valters Jansons To: location@lists.ipfire.org Subject: [PATCH] tests: Ensure loc_database_lookup finds a match Date: Mon, 7 Apr 2025 04:29:29 +0300 Message-ID: <20250407012929.19255-1-valter.jansons@gmail.com> X-Mailer: git-send-email 2.49.0 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: mail01.haj.ipfire.org X-Rspamd-Queue-Id: 4ZWBTV44NnzQt X-Spamd-Result: default: False [-7.93 / 11.00]; BAYES_HAM(-2.98)[99.92%]; R_DKIM_ALLOW(-1.68)[gmail.com:s=20230601]; NEURAL_HAM(-1.00)[-0.998]; DKIM_REPUTATION(-0.96)[-0.95548821311779]; IP_REPUTATION_HAM(-0.61)[asn: 15169(-0.26), country: US(-0.01), ip: 2a00:1450:4864:20::(-0.34)]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_MISSING_CHARSET(0.50)[]; SPF_REPUTATION_HAM(-0.39)[-0.38964757258368]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::129:from]; TO_DN_NONE(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TAGGED_FROM(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[location@lists.ipfire.org]; MID_RHS_MATCH_FROM(0.00)[]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[] X-Rspamd-Action: no action Commit 9e72b8a modified the lookup function to return 0 even if no matches are found. As result, the test case could pass even if the database lookup did not find any matches. This commit restores the original intent of the test case, by adding a failure condition when `network1` is NULL. This is similar to how the subsequent test case was modified for the inverse condition. --- I was checking https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021952 and wondering why the "Could not look up 2001:db8::" issue would suddenly disappear. This change popped up as a potential reason. So I am expecting hppa builds will start failing intermittently again. src/test-network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test-network.c b/src/test-network.c index 0cac1a4..73062f4 100644 --- a/src/test-network.c +++ b/src/test-network.c @@ -351,7 +351,7 @@ int main(int argc, char** argv) { // Lookup an address in the subnet err = loc_database_lookup_from_string(db, "2001:db8::", &network1); - if (err) { + if (err || !network1) { fprintf(stderr, "Could not look up 2001:db8::\n"); exit(EXIT_FAILURE); } -- 2.49.0