From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4jD4JW5ZTlz34GY for ; Mon, 26 Oct 2026 20:01:31 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1 raw public key) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "YR1" (not verified)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4jD4JV4qyfz2xNM for ; Mon, 26 Oct 2026 20:01:30 +0000 (UTC) Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4jD4JT5SHkzld for ; Mon, 26 Oct 2026 20:01:29 +0000 (UTC) Authentication-Results: mail01.ipfire.org; dkim=pass header.d=gmail.com header.s=20251104 header.b="NxrZ/xfW"; spf=pass (mail01.ipfire.org: domain of valter.jansons@gmail.com designates 2607:f8b0:4864:20::42e as permitted sender) smtp.mailfrom=valter.jansons@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; d=lists.ipfire.org; s=202003rsa; cv=none; t=1793044889; b=OiDvCqXGCh1VMymdNKl3Q6uM+nYXFbSukspnJP6OSFc5L5UgTme094GWTdPO6HbuidyVaQ dprB+8qWxqP1ZCE90qUwokhkBXMPZ9SAzn4vZ16lz4LepPJ5We/Uiy/y9ikWDVy/65pStK KineE4B0cr5RgMGBtTKYHcohDTuwTjQSJ8LTkpGnlCjRyLc6QZzQIL/eQzIiVMNK99EACI 6rDgVXo0KKkEeY2ZEhsTM+NCOHt00ecknfzmrraqJLn+G2tj7K+i8P5s6FTvCYpyVHYZWQ zRa8a6VuhBqI8FwMX1T47zKdCtk5sjIpvbULN+hW6u4GzuPfuJXhfY1PCDgj+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1793044889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:dkim-signature; bh=ct9SU+7ron3zBoxbupJVIbiKjTUyPuj8wIP8naXquzA=; b=x0d7Fvz0cIOj7YHXnKvG/S5G4uEa54sH31YeYLPHBV86V3zY8PpgJmpkby5BhgUDvrCtb1 SXpwlXP/e5qgu321WkZQAeAiUZIanKZkyvp3tyEgWA1aqQCiwrP8eJNB/mphhscx+AGFCc hXDex+zY8o5nszudDaNdZDG/dhyWSRyUlOZr34smGx7ieyVeG1LySwq3eE+FGDLdEn0I1q 47bf8C4marOuMjBHSnmpmsJPAqKcmtyZCjM5ySeb8v2lDqGvmJfXmHoTD9jZMIhDl3O3aS fjgp4mKKEV30DoGKWm1PJ1FbIGpVVHYd7SwG3FGnc3IEJJ6nL7b2b99tuM3+EA== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=gmail.com header.s=20251104 header.b="NxrZ/xfW"; spf=pass (mail01.ipfire.org: domain of valter.jansons@gmail.com designates 2607:f8b0:4864:20::42e as permitted sender) smtp.mailfrom=valter.jansons@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-8a06c60065fso2612501b3a.1 for ; Mon, 26 Oct 2026 13:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1793044888; x=1793649688; darn=lists.ipfire.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ct9SU+7ron3zBoxbupJVIbiKjTUyPuj8wIP8naXquzA=; b=NxrZ/xfWNiwsCaZXYXQqhZhGmtEsZoDmXe+cLmx+pJda9e44OrswsEa4UklXOV5kBc UMv5ohtCaKuMUR1HHla+6gDfggucJOhahJ2mo4iea8x+F0/ktW8uu9qdPSaqg0c1Ti0l LwcL0XHImhs0yY5Y7gJGIPdpuSHzJJWQEpwbnFp4w4GhZh4QX08FYSbLMNgZQl8vebuY KtDxotcBYLePAqivOL0RPBwbuuRgFEpKUpY2AI6hhxA9CX577DwfpOl9KDzFtR2C4Kot CkltGT7FgowcS/EwzdogViJQgWh2KiftlclBN3/olH5Wyv7Aw4jwflKNImv/iVnM9OwO TpKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793044888; x=1793649688; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ct9SU+7ron3zBoxbupJVIbiKjTUyPuj8wIP8naXquzA=; b=y1exxgxreFiGM6pF2c+Vn9GjN2AjvwEyCi5SiJiQaNqC2O8vx1cO8gzhDi0cFl7/We JFbWteIPGOwZdTePuC5TCVqDB6btSYNKWJdg3yKcHtBWPn4+/84vR65OrbmQvria1MeD XnPv4TNbsrb3HvnIVBZmutSNw3cdV973DA4WVjtZuuPkdGPlhJ3NNL86ZiYpg0niqIXG HrKwIs55wwWxbRSMZDXhHJErSUVdMOYMRyO7re+qCvZNnj9wOabKJ3YFJSMKClXH7gU5 ufNA7tIdMue4D0k8KaO7AILBtWpCaPFuY2/FZOwWU/+n9uYNRvOUI+WetwHgMwJJIB// nZbg== X-Gm-Message-State: AFq9FYKn1yYH0LJs0zPG21jYq0NAZ3MGpd1K8HyVMlCBLBbZQoFdwgjE WH88CpV9XhwQNOIjChYMPRDAuVORu+facLwevGccZhil91vUwwWO56ma92LdNzhi X-Gm-Gg: AYBFou3odpNh5TxBTUHX7lptaaDAOUv0hqqUg+uSp8Wz1ZRpmgS6O3+XBIWV79UsoSq rW9a5Wmfd9N1V7OSYk1mt7lMYr/pxFxEkx8y9H5+RTBWQKMiSUdklvZ6m3Sa5peJfpLGjsVnEgL X75PSbgC0rrP34P6vNBcKzV+WfbmRnnCT0vNrr3tqXtrcgm7KoloxZOEC549SwTFiwK7PjivyzL bwhcUafTiwvVQ1THkgeam1y8m0HtC105OlNWEw5qFofpfwefxzTmS2TYldER0+DzZ05VmciHger rFFMwlR6KdTZg6OulhdIp1O8dLguzDGaR0OOaxtdHXcd8Gj9pGhWXiIiACjewfVBHHZ3P2INsso exLcbnJwxZ2D2st7FdvgDvIK3IhEg2hMe6iMwnICQrY9a14vWYo3c3nCVxYbWn1iOrs0Kfp2vVz G+3RG7e4qrX+Hk3ffqL0gNAh46ZZSA9GKA5jArc1nNLHHs0SJJs+7X9A43ykx2yGNTNubekBreQ 2a8/qqM3Yk9yeD4xeVDfMSnzYUH763J6w7v0dwhK2b8J1lrVqwXbU0vj08E8Q7EK1vkFaJg X-Received: by 2002:a05:6a21:1f8a:b0:3e2:57b7:4d7e with SMTP id adf61e73a8af0-3e7af7ff285mr5781041637.10.1793044887650; Mon, 26 Oct 2026 13:01:27 -0700 (PDT) Received: from VT14-G5.localdomain ([221.146.12.107]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8a36ada287fsm1677731b3a.10.2026.10.26.13.01.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 13:01:26 -0700 (PDT) From: Valters Jansons To: location@lists.ipfire.org Subject: [PATCH] cron: Quietly abort if the package was removed Date: Tue, 27 Oct 2026 05:01:21 +0900 Message-ID: <20261026200122.551196-1-valter.jansons@gmail.com> X-Mailer: git-send-email 2.56.0 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-6.82 / 11.00]; BAYES_HAM(-3.00)[100.00%]; R_DKIM_ALLOW(-1.60)[gmail.com:s=20251104]; DKIM_REPUTATION(-0.97)[-0.96895864616197]; SPF_REPUTATION_HAM(-0.76)[-0.75795948704629]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_MISSING_CHARSET(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56]; R_DKIM_ALIGNED(-0.10)[strict]; MX_GOOD(-0.10)[gmail-smtp-in.l.google.com]; MIME_GOOD(-0.10)[text/plain]; IP_REPUTATION_HAM(0.00)[asn: 15169(-0.29), country: US(-0.01), ip: 2607:f8b0:4864:20::(-0.79)]; RCVD_TLS_LAST(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::42e:from]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; ALIAS_RESOLVED(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[location@lists.ipfire.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[] X-Rspamd-Server: mail01.haj.ipfire.org X-Rspamd-Queue-Id: 4jD4JT5SHkzld Previously, Debian was not installing the cron job. Now packaging it up and alerts about the risk of `/usr/bin/location` not being available. The scenario for this is that `/etc` contains configuration files, so running `apt remove location` would leave the cron job hanging. If it is a standard system with systemd, then the cron job expects systemd to manage everything. However, if the system doesn't have systemd, then the cron job will try to run a non-existant binary every day. This should be gracefully handled. --- src/cron/location-update.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cron/location-update.in b/src/cron/location-update.in index 6b1ebdc..8b7d23e 100644 --- a/src/cron/location-update.in +++ b/src/cron/location-update.in @@ -22,5 +22,10 @@ if [ -d /run/systemd/system ]; then exit 0 fi +# Quietly abort if the package has been removed but not purged +if [ ! -x @bindir@/location ]; then + exit 0 +fi + # Call the location database updater exec @bindir@/location update -- 2.56.0