From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4jDXNs0BHqz2yqg for ; Tue, 27 Oct 2026 14:06:53 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client CN "mail01.haj.ipfire.org", Issuer "YR1" (not verified)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4jDXNr05TKz2xGr for ; Tue, 27 Oct 2026 14:06:52 +0000 (UTC) Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mail01.ipfire.org (Postfix) with ESMTPS id 4jDXNq1YHFz4Rw for ; Tue, 27 Oct 2026 14:06:51 +0000 (UTC) Authentication-Results: mail01.ipfire.org; dkim=pass header.d=gmail.com header.s=20260707 header.b=H5KMFaZo; spf=pass (mail01.ipfire.org: domain of valter.jansons@gmail.com designates 2607:f8b0:4864:20::433 as permitted sender) smtp.mailfrom=valter.jansons@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; d=lists.ipfire.org; s=202003rsa; cv=none; t=1793110011; b=uOIcT2HjSDPDuoA+mtF9wNOIwbSNB9U5h7iMSHx7B2niNn96JS66fD+n3ahV2rMZNYr/yq vraQEEPh/L6UGEP/kcqWH9EZ4tSewYtpDlp4g37/J+RBg0R7Y7HNAjv4eaJsoc/rJ0Szhk ch0/iLikQfXYS9H/ERH0FPLjq3J/zSSwVj8fkoBGdaiRGY4ouwbl3AFy5wZ3ZRCRg8Y4Vp pCeZ+qom7cCU+JdDjgWDi5Pyjp7uis2f+LrGdvdlrtrZQgcnkz9islc3zYnJszTxIYiZMr aByIc7fJwH+3kNJ4b5L/m9zQmkeqovgTH1JcEFDhes5xhxvPVm1KFnfvrPM/UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1793110011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LqxWH2tCA+slGvJIPRamiFYJPmWyEf9pRmx/1M6ZwKk=; b=nBim1cCJ09h+1kUyQjLpPSWcDb8jpcgsmU9eCbP3J2WfaYFXtJG07zNhOK7gBEXt2LfQd3 x3jvMG+ZTgN7bAMDeZF/z7ELoVpb/HD+s7RWGZmSCzORL5UDVP7RFxG1ocFsASFd98iAmF E4sVvVpc4S7tWi2Pr980vyySKkbmqzqUpy08t/ibJ2+ksZ7wZzq0aWYbs0Oqelq7+xVbaR e3bsQ68LRUPg8c8bZyqfgvc3Mvu7QkfxSalezePNd8iTmsCAMapT5n2HOiY2kaaCaI+ru6 QLbghEARpnTml0JU6nyb8GInO9qCJPvbxGFA4ygOXAJBhSwpcHORZJT+o5VYxQ== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=gmail.com header.s=20260707 header.b=H5KMFaZo; spf=pass (mail01.ipfire.org: domain of valter.jansons@gmail.com designates 2607:f8b0:4864:20::433 as permitted sender) smtp.mailfrom=valter.jansons@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-8a070781f63so1620091b3a.1 for ; Tue, 27 Oct 2026 07:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793110009; x=1793714809; darn=lists.ipfire.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=LqxWH2tCA+slGvJIPRamiFYJPmWyEf9pRmx/1M6ZwKk=; b=H5KMFaZoaGeb5VckQFDT1khAMSLRjX0l8nzix6HTqMJ5r9UVr1gczU+NrQMv37H/L+ sgbrwiWGyIF7SGXKbrV9RLVfphxzIRjY4MQDlE2nGu1pn/oI/TUkOW/7324q3LeMiD1R HkCgEbSkK9Sd6h7YQs/WBaRmcsMadPTsKyJGKyokibq69JWRvoGOP3l/mZm8DwtpYL66 1KARfE/pJaWbwCFsjtqZsWjhRQ3vrMU+pj/OrFA/G0FWnWg5WdAJ40nfCTT32D7kWnB6 UG02nBwuYFNiLTkFTE6DlKiwO4tc9rLfI87oaR+v4UFIsYFWteoUHr41Qu0tdfcBGF3r CLdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793110009; x=1793714809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=LqxWH2tCA+slGvJIPRamiFYJPmWyEf9pRmx/1M6ZwKk=; b=KsJigohSNGodlpPybtQskGaAYIGp+UkhlQeuZH5P79myLK8zbWrT01gRA4OrDcnp3E yHCedo0yhWJpvC4dkmQGI/i9/i/ts1KMAbEjP5jsvzoOY7sbN/Udd2P43MAazKuL2UA5 nABWRlvpvSLMNZHTC2jZ7Mv/RkK7HM4B3jmTwsg3eRtclDb0LSH4ieKb9NxSKgUO2R/x gORy45BUOmX+OqWzjqNYvSJx4SkbFTgfIXUuAQVv/uuVXQoUr4NKlM1lIgzEmoUvH7JG y/YOA6dZzMc1TpXR6PzzL8FY2l7F0GU1VsxuZS//kYU9ks5RUg2IJil9GNrlUg4CsR6S aiog== X-Gm-Message-State: AFq9FYIRNRJJtqiREWOvz2p6gVvvCIkatWGNB9kX2LWf5cDAsFZGXYLu WWSa7fFXtbGDkrwkFpPiYSZRadLcNC/+Ty0H8ZFgDhaQCryroTxYcZpBH5w6eTti X-Gm-Gg: AYBFou26Qz6+B2byaHkkqKzWHSiED1xLWp2fAGSlpcRbhXrHaz8LgxtZfo9+foImVCy PMtyiBTbUE87KNST3pLDtKLedeeAtFpvEnAJCqi5G+i++UTLhDy3KvSv8mQrzuvFaEV0jlj3aTj 2p0D1eSDpyTW8R41Vif3fdXt3n80D3y21sNP+WQ8jzqdpmDztVLANwPxXjptFSZGbqE1ZHA6Fb2 ylPXrWpp2ABTaxmc40Zv40jhfUmvw6o7nXawf3Hxb4Ed8mE7h9fzltbVtHhvPxXgDMhAJXAUt/f sJtTghD88Bc4vzpjOD1TlykfleDYoaQLF/uVYNf/K+Tis20XtsWF0z72v/+kN73T8xHx5KWUgeI FKPPYeDWj/NLSz75tDlOfkfh3FISPqmEodg2Ez7sLNpBJVngpxNDZs4lJCmqQeBksjJR3xOyf3O q5ledCrml3SNiuy/qlf/GtjYQaub1iXoV/h+GGyvpEzgvyW6W0TJ32rwv6AIDVsiTYzrCDMZVJb zChM8v3eBjyHT0CGJ9g36+7byjgsBowT9lX1N7OmXUBqzOWNl2X/07LQQkZAgVngPcyH7rI X-Received: by 2002:a05:6a00:2448:b0:89e:9c7e:fd51 with SMTP id d2e1a72fcca58-8a367a367c1mr8260348b3a.10.1793110008749; Tue, 27 Oct 2026 07:06:48 -0700 (PDT) Received: from VT14-G5.localdomain ([221.146.12.107]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8a6a6cf9489sm63086b3a.39.2026.10.27.07.06.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2026 07:06:48 -0700 (PDT) From: Valters Jansons To: location@lists.ipfire.org Subject: [PATCH] cron: Quietly abort if the package was removed Date: Tue, 27 Oct 2026 23:06:40 +0900 Message-ID: <20261027140640.22015-1-valter.jansons@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261026200122.551196-1-valter.jansons@gmail.com> References: <20261026200122.551196-1-valter.jansons@gmail.com> Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-6.83 / 11.00]; BAYES_HAM(-3.00)[100.00%]; R_DKIM_ALLOW(-1.60)[gmail.com:s=20260707]; DKIM_REPUTATION(-0.97)[-0.96869017527773]; SPF_REPUTATION_HAM(-0.77)[-0.76580386799223]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_MISSING_CHARSET(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; MIME_GOOD(-0.10)[text/plain]; R_DKIM_ALIGNED(-0.10)[strict]; MX_GOOD(-0.10)[gmail-smtp-in.l.google.com]; FROM_EQ_ENVFROM(0.00)[]; IP_REPUTATION_HAM(0.00)[asn: 15169(-0.30), country: US(-0.01), ip: 2607:f8b0:4864:20::(-0.80)]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_NONE(0.00)[]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; MID_RHS_MATCH_FROM(0.00)[]; ALIAS_RESOLVED(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[location@lists.ipfire.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::433:from]; FROM_HAS_DN(0.00)[] X-Rspamd-Server: mail01.haj.ipfire.org X-Rspamd-Queue-Id: 4jDXNq1YHFz4Rw Previously, Debian was not installing the cron job. Now packaging it up alerts about the risk of `/usr/bin/location` not being available. The scenario for this is that `/etc` contains configuration files, so running `apt remove location` would leave the cron job hanging. If it is a standard system with systemd, then the cron job expects systemd to manage everything. However, if the system doesn't have systemd, then the cron job will try to run a non-existant binary every day. This should be gracefully handled. Signed-off-by: Valters Jansons --- Re-submitting patch with an explicit `Signed-off-by`. Sorry. src/cron/location-update.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cron/location-update.in b/src/cron/location-update.in index 6b1ebdc..8b7d23e 100644 --- a/src/cron/location-update.in +++ b/src/cron/location-update.in @@ -22,5 +22,10 @@ if [ -d /run/systemd/system ]; then exit 0 fi +# Quietly abort if the package has been removed but not purged +if [ ! -x @bindir@/location ]; then + exit 0 +fi + # Call the location database updater exec @bindir@/location update -- 2.56.0