From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: [PATCH] location-importer.in: Do not make things more complicated than they are
Date: Mon, 20 Dec 2021 17:54:48 +0100 [thread overview]
Message-ID: <20697DD1-6F58-4304-90FD-82E21D7A37B5@ipfire.org> (raw)
In-Reply-To: <b9338bb9-1212-dccf-d134-c8a91fff2b46@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> On 18 Dec 2021, at 13:57, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Suggested-by: Michael Tremer <michael.tremer(a)ipfire.org>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> src/python/location-importer.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/python/location-importer.in b/src/python/location-importer.in
> index 118b0de..f39a42b 100644
> --- a/src/python/location-importer.in
> +++ b/src/python/location-importer.in
> @@ -687,7 +687,7 @@ class CLI(object):
> start_address = ipaddress.ip_network(start_address, strict=False)
> except ValueError:
> start_address = start_address.split("/")
> - ldigits = len(start_address[0].split("."))
> + ldigits = start_address[0].count(".")
>
> # How many octets do we need to add?
> # (LACNIC does not seem to have a /8 or greater assigned, so the following should suffice.)
> --
> 2.26.2
prev parent reply other threads:[~2021-12-20 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 12:57 Peter Müller
2021-12-20 16:54 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20697DD1-6F58-4304-90FD-82E21D7A37B5@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox