From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: Warning in '__loc_network_tree_count()'
Date: Sat, 04 Mar 2023 10:51:42 +0000
Message-ID: <34085602-5207-4A22-9C9D-34292A3A3344@ipfire.org>
In-Reply-To: <5474f77e-e2a8-16d9-6c27-28c976dbebbd@online.no>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0109657267355411136=="
List-Id: <location.lists.ipfire.org>

--===============0109657267355411136==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Gisle,

Thanks for your email.

> On 4 Mar 2023, at 10:44, Gisle Vanem <gvanem(a)online.no> wrote:
>=20
> Hello list.
>=20
> Compiling with 'clang-cl' on Windows-10, I saw this
> important warning:
> network.c(796,10): warning: variable 'counter' set but not used [-Wunused-b=
ut-set-variable]
>   size_t* counter =3D (size_t*)data;
>           ^
>=20
> So shouldn't the function be:
>=20
> static int __loc_network_tree_count(struct loc_network* network, void* data=
) {
> size_t* counter =3D (size_t*)data;
>=20
> // Increase the counter for each network
> (*counter)++;
> return 0;

Yes, you are incorrect. I am incrementing the pointer when I wanted to increm=
ent the value. Probably this is an artefact from rewriting the code a few tim=
es.

But indeed this has not been a problem since the function is not being called=
 at all in the code, and it is not being exported.

So assuming that it is not very useful, I will drop loc_network_tree_count_ne=
tworks and the callback function.

Thank you for helping to improve libloc. How does it run on Windows?

Best,
-Michael

> }
>=20
> But I fail to see this ret-val is used for anything.
>=20
> BTW, disasm now is correct:
> inc qword ptr [rdx]
> xor eax,eax
> ret
>=20
>=20
> --=20
> --gv


--===============0109657267355411136==--