Re: Segfault on d5ff39d "tree: Actually delete any deleted nodes"

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

Hello Valters,

Thanks for reviewing my changes. This was indeed a thing that I did observe as well and fixed it right here:

  https://git.ipfire.org/?p=location/libloc.git;a=commitdiff;h=0e894966750e89d1b83c6ad90f37945d4d349118

The root node got deleted and lots of the code just relied on it being there. Especially when the tree was empty.

-Michael

> On 17 Jul 2023, at 19:35, Valters Jansons <valter.jansons(a)gmail.com> wrote:
> 
> Hi,
> 
> I am seeing a segfault during tests (src/test-as, src/test-country and
> src/test-signature) for all Ubuntu LTS versions. This only occurs with
> the latest commit (d5ff39d) applied. Looking at the change, the node
> still seems to be used after dereference, but I am not fully sure of
> the way you have planned out the deletion, therefore I am not offering
> a patch/resolution.
> 
> From gdb I am seeing:
> 
> Program received signal SIGSEGV, Segmentation fault.
> loc_network_tree_delete_nodes (tree=0x55555555a370) at src/network.c:1045
> 1045            tree->root->deleted = 0;
> 
> Best regards,
> Valters Jansons