From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: [PATCH] location-importer: Fix parsing LACNIC-flavoured inetnums
Date: Wed, 02 Mar 2022 16:37:38 +0000 [thread overview]
Message-ID: <3740D80F-2CB1-422B-B507-B1D47386E0FC@ipfire.org> (raw)
In-Reply-To: <5e2c3c46-f8e5-8b2a-45bf-04c925f65f73@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]
Thank you. Does this mean we are getting closer to tagging another release?
-Michael
> On 1 Mar 2022, at 21:52, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> My fault, again. :-/
>
> Reported-by: Michael Tremer <michael.tremer(a)ipfire.org>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> src/python/location-importer.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/python/location-importer.in b/src/python/location-importer.in
> index 83fb5c7..fe13482 100644
> --- a/src/python/location-importer.in
> +++ b/src/python/location-importer.in
> @@ -3,7 +3,7 @@
> # #
> # libloc - A library to determine the location of someone on the Internet #
> # #
> -# Copyright (C) 2020-2021 IPFire Development Team <info(a)ipfire.org> #
> +# Copyright (C) 2020-2022 IPFire Development Team <info(a)ipfire.org> #
> # #
> # This library is free software; you can redistribute it and/or #
> # modify it under the terms of the GNU Lesser General Public #
> @@ -691,9 +691,9 @@ class CLI(object):
>
> # How many octets do we need to add?
> # (LACNIC does not seem to have a /8 or greater assigned, so the following should suffice.)
> - if ldigits == 2:
> + if ldigits == 1:
> start_address = start_address[0] + ".0.0/" + start_address[1]
> - elif ldigits == 3:
> + elif ldigits == 2:
> start_address = start_address[0] + ".0/" + start_address[1]
> else:
> log.warning("Could not recover IPv4 address from line in LACNIC DB format: %s" % line)
> --
> 2.34.1
next prev parent reply other threads:[~2022-03-02 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 21:52 Peter Müller
2022-03-02 16:37 ` Michael Tremer [this message]
2022-03-02 16:41 ` Peter Müller
2022-03-02 16:44 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3740D80F-2CB1-422B-B507-B1D47386E0FC@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox