From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: [PATCH] debian: Attribute all maintainers in changlog
Date: Mon, 14 Jun 2021 10:36:50 +0100
Message-ID: <3B9DA78C-B065-402D-A38B-EAF00C7AA712@ipfire.org>
In-Reply-To: <20210613161625.20616-1-valter.jansons@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0922981406023627469=="
List-Id: <location.lists.ipfire.org>

--===============0922981406023627469==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Valters,

Thank you very much for this patch. I have a general question regarding this:

Since we have a number of packages that we package for Debian, is it a good s=
trategy to add so many scripts and replicate them across the different reposi=
tories? It seems that this will get complicated in the future where improveme=
nts might not be copied to all repositories, etc.

How can we combat that?

-Michael

> On 13 Jun 2021, at 17:16, Valters Jansons <valter.jansons(a)gmail.com> wrot=
e:
>=20
> This commit further builds on historical changelog modifications,
> to properly attribute all authors of the commits.
>=20
> An additional d/genchangelog.sh script has been added. This allows
> generation of changelog entries, internally using `debchange` (`dch`).
> The script accepts an argument, which is the commit range to generate
> entries for. Each commit's subject line (first line of body) is used,
> along with author name and email. This information is added to the
> changelog. Automatic detection (via `debchange` built-in functionality)
> is used to determine whether these entries should be added to an
> existing version number. If there is no UNRELEASED version, then a new
> version is automatically tagged.
>=20
> The new version tag will usually need to be modified, for example,
> replacing an automatically generated 0.9.6-2 with 0.9.7-1.
>=20
> The final release change (s/UNRELEASED/unstable/) needs to be done
> manually as well, when the Git tag is actually being tagged.
> `dch -r` can be useful for this particular purpose.
>=20
> Signed-off-by: Valters Jansons <valter.jansons(a)gmail.com>
> ---
> debian/changelog       | 15 +++++++++------
> debian/genchangelog.sh | 36 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 45 insertions(+), 6 deletions(-)
> create mode 100755 debian/genchangelog.sh
>=20
> diff --git a/debian/changelog b/debian/changelog
> index e58c0ca..6817fb3 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,13 +1,16 @@
> libloc (0.9.6-1) unstable; urgency=3Dmedium
>=20
> -  * location-importer.in: skip networks with unknown country codes
> -  * location-importer.in: process unaligned IP ranges in RIR data files
> -    correctly
> +  [ Michael Tremer ]
> +  * location: Fix list-networks-by-as
>   * database: Free mmapped countries section
> -  * location-importer.in: reduce log noise for unusable networks
> -  * location-importer.in: delete 6to4 IPv6 space as well
> +
> +  [ Peter M=C3=BCller ]
>   * location-importer.in: fix typo
> -  * location: Fix list-networks-by-as
> +  * location-importer.in: delete 6to4 IPv6 space as well
> +  * location-importer.in: reduce log noise for unusable networks
> +  * location-importer.in: process unaligned IP ranges in RIR data files
> +    correctly
> +  * location-importer.in: skip networks with unknown country codes
>=20
>  -- Michael Tremer <michael.tremer(a)ipfire.org>  Wed, 31 Mar 2021 14:06:00=
 +0100
>=20
> diff --git a/debian/genchangelog.sh b/debian/genchangelog.sh
> new file mode 100755
> index 0000000..85d3922
> --- /dev/null
> +++ b/debian/genchangelog.sh
> @@ -0,0 +1,36 @@
> +#!/bin/bash -e
> +gitshow () {
> +  local format=3D$1
> +  local commit=3D$2
> +
> +  git show --no-patch --format=3Dformat:"$format" "$commit"
> +}
> +
> +main () {
> +  if [ $# -lt 1 ]; then
> +    local bn=3D"$(basename $0)"
> +    echo "Usage:    $bn  <commit range>" >&2
> +    echo "Example:  $bn  0.9.7..HEAD" >&2
> +    echo "Example:  $bn  0.9.5..0.9.6^" >&2
> +    return 1
> +  fi
> +
> +  local commitrange=3D$1
> +
> +  local commit
> +  for commit in $(git rev-list --reverse "$commitrange"); do
> +    # Skip commits with diffs that only have Makefile.am or d/ changes.
> +    if [ "$(git diff --name-only "${commit}^..${commit}" -- . ':^Makefile.=
am' ':^debian/' | wc -l)" =3D=3D 0 ]; then
> +      continue
> +    fi
> +
> +    local author_name=3D"$(gitshow %an "$commit")"
> +    local author_email=3D"$(gitshow %ae "$commit")"
> +    local subject=3D"$(gitshow %s "$commit")"
> +
> +    echo "$author_name <$author_email>  $subject"
> +    DEBFULLNAME=3D"$author_name" DEBEMAIL=3D"$author_email" debchange --up=
stream --multimaint-merge "$subject"
> +  done
> +}
> +
> +main "$@" || exit $?
> --=20
> 2.32.0
>=20


--===============0922981406023627469==--