From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gisle Vanem To: location@lists.ipfire.org Subject: mem-map leak in loc_database_free() Date: Sun, 21 Mar 2021 17:35:58 +0100 Message-ID: <45bfe380-44a1-5e0a-2e8f-d8fb7bf8e8fa@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6280385571923144096==" List-Id: --===============6280385571923144096== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello list. In my Windows program I use the 'libloc' library and the compressed 'location.db.xz' file. I also have some functions to download, decompress to a temp-file. Then finally using 'CopyFile()' to update to the final .db-file. But my problem was that 'CopyFile()' failed with error 'ERROR_USER_MAPPED_FILE' since some regions to the file was not closed. I saw that 'libloc' does 5 calls to 'mmap()' but only 4 calls to 'munmap()' in 'loc_database_free()'; the freeing of 'db->countries_v1' is missing. So with this patch my program works fine: --- a/database.c 2020-12-03 15:04:38 +++ b/database.c 2021-03-21 17:21:04 @@ -446,6 +446,13 @@ ERROR(db->ctx, "Could not unmap network nodes sectio= n: %s\n", strerror(errno)); } + // Remove mapped countries nodes section + if (db->countries_v1) { + r =3D munmap(db->countries_v1, db->countries_count * sizeof(*= db->countries_v1)); + if (r) + ERROR(db->ctx, "Could not unmap countries nodes secti= on: %s\n", strerror(errno)); + } + if (db->pool) loc_stringpool_unref(db->pool); --------- Not sure how 'libloc' could work w/o this on Linux. What does a 'cp /tmp/location.db location-in-use.db' say when running one of the test programs in parallel? --=20 --gv --===============6280385571923144096==--