public inbox for location@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: [PATCH] debian: Add intltoolize to dh_auto_configure
Date: Wed, 07 Apr 2021 16:08:24 +0100	[thread overview]
Message-ID: <4F3D1034-42F2-4FA4-9DD5-F20C553BC088@ipfire.org> (raw)
In-Reply-To: <CA+sCei2yFes5MN_Ldsd=OdES6orNQi=ehpP+PpUtG7CFwf9aLA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

Hello Valters,

Thank you very much for your patch.

It didn’t apply because all tabs were replaced by spaces in this email. I took care of this manually and pushed it into the master branch.

Do you have any more experience with the Debian build system? We kind of put this together without a lot of background knowledge and have a couple of (probably minor) things that could need fixing. Are you able to help?

-Michael

> On 6 Apr 2021, at 12:13, Valters Jansons <valter.jansons(a)gmail.com> wrote:
> 
> Debian has automated building tools that handle source trees directly.
> It is expected that you can pick up a source tarball, and with the
> appropriate debian/ subtree, a successful build can be produced using
> the `debuild` tool. This depends on all the build steps having been
> included as part of the debian/rules file (see: `man debuild`).
> 
> This commit ensures there is no need to manually run autogen.sh
> on a locally extracted source tarball prior to building for Debian.
> This is accomplished by adding the `intltoolize` command to the
> override_dh_auto_configure step in d/rules.
> 
> There is no need to add the `autoreconf` command due to dh-autoreconf
> always handling that prior to the dh_auto_configure step.
> ---
> debian/rules | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/debian/rules b/debian/rules
> index 4e544d7..8893b7b 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -10,6 +10,7 @@ export DEB_BUILD_MAINT_OPTIONS=hardening=+all
>        dh $@ --with python3 --with-systemd
> 
> override_dh_auto_configure:
> +       intltoolize --force --automake
>        dh_auto_configure -- --disable-perl
> 
> override_dh_perl:
> --
> 2.31.1


  reply	other threads:[~2021-04-07 15:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 11:13 Valters Jansons
2021-04-07 15:08 ` Michael Tremer [this message]
2021-04-12 12:50   ` Valters Jansons
2021-04-13 18:53     ` Michael Tremer
2021-04-20  9:21       ` Valters Jansons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3D1034-42F2-4FA4-9DD5-F20C553BC088@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=location@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox