From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: [PATCH] debian: Add intltoolize to dh_auto_configure
Date: Wed, 07 Apr 2021 16:08:24 +0100
Message-ID: <4F3D1034-42F2-4FA4-9DD5-F20C553BC088@ipfire.org>
In-Reply-To:
 <CA+sCei2yFes5MN_Ldsd=OdES6orNQi=ehpP+PpUtG7CFwf9aLA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2380872012705768708=="
List-Id: <location.lists.ipfire.org>

--===============2380872012705768708==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Valters,

Thank you very much for your patch.

It didn=E2=80=99t apply because all tabs were replaced by spaces in this emai=
l. I took care of this manually and pushed it into the master branch.

Do you have any more experience with the Debian build system? We kind of put =
this together without a lot of background knowledge and have a couple of (pro=
bably minor) things that could need fixing. Are you able to help?

-Michael

> On 6 Apr 2021, at 12:13, Valters Jansons <valter.jansons(a)gmail.com> wrote:
>=20
> Debian has automated building tools that handle source trees directly.
> It is expected that you can pick up a source tarball, and with the
> appropriate debian/ subtree, a successful build can be produced using
> the `debuild` tool. This depends on all the build steps having been
> included as part of the debian/rules file (see: `man debuild`).
>=20
> This commit ensures there is no need to manually run autogen.sh
> on a locally extracted source tarball prior to building for Debian.
> This is accomplished by adding the `intltoolize` command to the
> override_dh_auto_configure step in d/rules.
>=20
> There is no need to add the `autoreconf` command due to dh-autoreconf
> always handling that prior to the dh_auto_configure step.
> ---
> debian/rules | 1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/debian/rules b/debian/rules
> index 4e544d7..8893b7b 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -10,6 +10,7 @@ export DEB_BUILD_MAINT_OPTIONS=3Dhardening=3D+all
>        dh $@ --with python3 --with-systemd
>=20
> override_dh_auto_configure:
> +       intltoolize --force --automake
>        dh_auto_configure -- --disable-perl
>=20
> override_dh_perl:
> --
> 2.31.1


--===============2380872012705768708==--