From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gisle Vanem <gvanem@online.no>
To: location@lists.ipfire.org
Subject: Warning in '__loc_network_tree_count()'
Date: Sat, 04 Mar 2023 11:44:33 +0100
Message-ID: <5474f77e-e2a8-16d9-6c27-28c976dbebbd@online.no>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2422548066238604014=="
List-Id: <location.lists.ipfire.org>

--===============2422548066238604014==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello list.

Compiling with 'clang-cl' on Windows-10, I saw this
important warning:
network.c(796,10): warning: variable 'counter' set but not used [-Wunused-but=
-set-variable]
    size_t* counter =3D (size_t*)data;
            ^

So shouldn't the function be:

static int __loc_network_tree_count(struct loc_network* network, void* data) {
	size_t* counter =3D (size_t*)data;

	// Increase the counter for each network
	(*counter)++;
	return 0;
}

But I fail to see this ret-val is used for anything.

BTW, disasm now is correct:
  inc qword ptr [rdx]
  xor eax,eax
  ret


--=20
--gv

--===============2422548066238604014==--