Re: Problem in urllib?

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2468 bytes --]

Hello,

> On 30 Mar 2021, at 12:14, Gisle Vanem <gisle.vanem(a)gmail.com> wrote:
> 
> Michael Tremer wrote:
> 
>> Please just update to the 0.9.5 release and this problem will be fixed.
> 
> I seems to have that; git describe --tags
> 0.9.5-9-g1814283
> 
> It was only that the '0.9.4' was a left-over in my
> build. What specific change after 0.9.4 did fix this?

This was a server-side change where we blocked clients with version 0.9.4 or older to download the databases. They have been changed which could have caused some damage on some systems, so we took this precautionary step.

> But rebuilding such that 'User-agent: location/0.9.5',
> and a little path to 'python/database.c', it seems to
> work better:
> ...
> HTTP Response: 200
>        Headers:
>                date: Tue, 30 Mar 2021 10:52:03 GMT
>                last-modified: Tue, 30 Mar 2021 05:06:07 GMT
>                etag: "425158-5beb9f4bc1867"
>                accept-ranges: bytes
>                content-length: 4346200
>                x-content-type-options: nosniff
>                x-frame-options: deny
>                referrer-policy: strict-origin
>                x-xss-protection: 1; mode=block
>                content-type: application/x-xz
>                strict-transport-security: max-age=31536000; includeSubDomains; preload
>                connection: close
> Downloaded new database from Tue, 30 Mar 2021 05:04:14 GMT
> Traceback (most recent call last):
>  File "f:\ProgramFiler\Python36\lib\shutil.py", line 544, in move
>    os.rename(src, real_dst)
> FileExistsError: [WinError 183] Kan ikke opprette en fil når
> filen allerede finnes: 'f:\\gv\\VC_project\\ws_trace\\tmp82
> 8kmqif' -> 'f:\\gv\\VC_project\\ws_trace\\IPFire-database.db'
> 
> -----------
> 
> Some issue with shutil when overwriting/renaming an existing
> .db-file. But updating w/o a .db-file works fine.

I cannot exactly decipher why Windows would complain here. We are replacing the file because we cannot change it when it is open using mmap(). Maybe Windows does not allow that?

> PS. it would be nice that 'location.py --debug' would honour
> the setting of 'LOC_LOG'. w/o this it's very hard to see
> what goes on in the Python module.

You can always set LOC_LOG=debug, but you will need to build the library with debugging to see more output.

The Python code should always print debugging information if enabled.

-Michael